Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new game : dinosaur memory game added #3250

Merged
merged 6 commits into from
May 19, 2024

Conversation

shellygarg10
Copy link
Contributor

@shellygarg10 shellygarg10 commented May 13, 2024

PR Description 📜

Dinosaur Memory Game is a classic memory game with a twist! Players will be presented with a grid of facedown cards featuring dinosaurs related images. Clicking on a card will reveal the image. The objective is to find matching pairs by flipping over two cards at a time.
Fixes #3244


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Screenshot 2024-05-13 194114



Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented May 13, 2024

Thank you @shellygarg10 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@shellygarg10
Copy link
Contributor Author

Hi @kunjgit , Just checking in to see if you have a chance to review my pull request. The pull request seems to have passed all checks. Is there anything else I need to do before it can be merged?

@kunjgit
Copy link
Owner

kunjgit commented May 15, 2024

@shellygarg10 make sure you are adding your game in main readme file !

@shellygarg10
Copy link
Contributor Author

@kunjgit i have updated the readme file please check

Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shellygarg10 add image in assets !

@shellygarg10
Copy link
Contributor Author

@kunjgit updated the assets as well

@kunjgit
Copy link
Owner

kunjgit commented May 17, 2024

@shellygarg10 in root of repository there is readme file that keeps track of all the games there on GameZone there you have to add that entry !
please try to read documentation properly !

@shellygarg10
Copy link
Contributor Author

hi @kunjgit ! I've carefully reviewed the README file and resolved any conflicts with the base branch. The updated version should merge cleanly. Please take a look at the changes and let me know if you have any questions. This is my first time contributing to an open-source project, so I'm sorry for not being able to do it as required initially but I appreciate your patience!

@shellygarg10 shellygarg10 requested a review from kunjgit May 17, 2024 15:34
@kunjgit kunjgit added level3 Adding new features gssoc GSSoC24 program label and removed Pending ⏱️ labels May 19, 2024
Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kunjgit kunjgit merged commit c85d160 into kunjgit:main May 19, 2024
1 check passed
@kunjgit
Copy link
Owner

kunjgit commented May 19, 2024

Thank you @shellygarg10 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC24 program label level3 Adding new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New game]: . Dinosaur Memory Game
3 participants