Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart and start button functionality updated #3236

Closed
wants to merge 4 commits into from

Conversation

Tasnuva12
Copy link
Contributor

@Tasnuva12 Tasnuva12 commented May 13, 2024

PR Description πŸ“œ

I addressed the issue regarding the start and restart buttons, which initially seemed to be malfunctioning. However, upon closer inspection, it became apparent that they were functioning as intended. The only concern was the lack of visual feedback to indicate when the game was starting and ending. Consequently, I updated the functionality of both buttons to provide clear visual cues, ensuring users understand precisely when the game begins and concludes.


Mark the task you have completed βœ…

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) πŸ“Έ



Thank you soo much for contributing to our repository πŸ’—

-renamed  the "Restart" button to "Reset" for clarity.
-ensured that the letter won't popup until the "Start" button is pressed.
-stopped the popup of the letter when the "Reset" button is pressed.
-enhance the functionality of both buttons to make it clear when the game starts and when it's reset.
-updated the hover and active effect of the button to change the color  during this events
@kunjgit
Copy link
Owner

kunjgit commented May 13, 2024

Thank you @Tasnuva12 ,for creating the PR and contributing to our GameZone πŸ’—
Review team will review the PR and will reach out to you soon! πŸ˜‡
Make sure that you have marked all the tasks that you are done with βœ….
Thank you for your patience! πŸ˜€

@Tasnuva12 Tasnuva12 marked this pull request as ready for review May 13, 2024 11:18
@Tasnuva12
Copy link
Contributor Author

Hello , Please check my PR now and let me know if I have done anything wrong .Thanks !

@Tasnuva12 Tasnuva12 changed the title Tm12 Restart and start button functionality updated May 14, 2024
I changed the color palette of the entire page to make it look good
@kunjgit kunjgit closed this May 17, 2024
@kunjgit
Copy link
Owner

kunjgit commented May 17, 2024

Hey @Tasnuva12,
You can't work on a closed issue πŸ‘€!
Follow the proper guideline and make a new PR again πŸ˜€.
Happy Hacking πŸ’—

@kunjgit
Copy link
Owner

kunjgit commented May 17, 2024

Thank you @Tasnuva12 , for your valuable time and contribution in our GameZone πŸ’—.
It’s our GameZone, so Let’s build this GameZone altogether !!🀝
Hoping to see you soon with another PR again πŸ˜‡
Wishing you all the best for your journey into Open SourceπŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Master typing -start/restart button non-functionality bug
2 participants