Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add columns component #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dotamir
Copy link

@dotamir dotamir commented Dec 18, 2017

No description provided.

@dotamir
Copy link
Author

dotamir commented Dec 18, 2017

I've just made the basics. It will be complete, And please left your comments and lemme know what you think and what is your idea?
Let's work together on this.

@dotamir dotamir changed the title Feature/add columns components Feature/add columns component Dec 18, 2017
@skbolton
Copy link

I am really hopeful for this to get added but I think some changes could be made.
The text alignment can always be passed in as a className so it just adds overhead to the api and documentation. Also I think having the gap and multiline props would be nice

@dotamir
Copy link
Author

dotamir commented Dec 27, 2017

@skbolton Yeah, I'm with you. And I've deleted the text alignments. Also, I'll commit the new changes.

@skbolton
Copy link

skbolton commented Jan 3, 2018

I think to match the api elsewhere the is part of the props should be dropped so

<Columns multiline gapless>
  <Column is={2}>
    <h1>Hey there</h1>
  </Column>
</Columns>

instead of

<Columns isMultiline isGapless>
  <Column is="is-2">
    <h1>Hey there</h1>
  </Column>
</Columns>
  

@dotamir
Copy link
Author

dotamir commented Jan 10, 2018

@skbolton Can you do that? I just busy right now.

@skbolton
Copy link

Yeah I can get it

@kulakowka kulakowka mentioned this pull request Apr 20, 2018
@dotamir
Copy link
Author

dotamir commented May 8, 2018

@kulakowka Let's work on it together. What's your idea about it until here?
gimme a feedback and I'll complete this.

@scorsi
Copy link

scorsi commented Sep 16, 2018

Do you have some news about the Columns feature progress ? :)

@juanbrujo
Copy link

This feature is important, will be fixed and merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants