Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to v49.0.0 #1153

Closed
wants to merge 2 commits into from
Closed

update to v49.0.0 #1153

wants to merge 2 commits into from
+12 −33

Conversation

drivesketch
Copy link
Contributor

@drivesketch drivesketch commented May 10, 2024 •
edited

課題・背景

やったこと

  • SmartHR UIを v49.0.1（最新） ←こいつは不具合が出るので v49.0.0 にアップデート

やらなかったこと

  • 何らかのページの変更など（不要だったため）

動作確認

キャプチャ

Before After

@netlify Netlify
Copy link

netlify bot commented May 10, 2024 •
edited

✅ Deploy Preview for smarthr-design-system ready!

Name Link
🔨 Latest commit 4330b07
🔍 Latest deploy log https://app.netlify.com/sites/smarthr-design-system/deploys/6641ab69833003000872fb77
😎 Deploy Preview https://deploy-preview-1153--smarthr-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@oremega oremega requested review from oremega, uknmr and tosiiu May 10, 2024 07:37
oremega
oremega reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@oremega oremega left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コンポーネントのコードを表示しているところが 404: Not Foundになっているのが大丈夫なのかわからなかったです。
@uknmr このへん原因わかります？ローカルだからですかね？
コンポーネントページのStorybookを描画している画面のキャプチャ

@drivesketch drivesketch changed the title update to v49.0.1 update to v49.0.0 May 13, 2024
@drivesketch drivesketch requested a review from oremega May 13, 2024 06:28
@drivesketch drivesketch disabled auto-merge May 13, 2024 06:42
@drivesketch
Copy link
Contributor Author

  • 最新に上げると不具合が出る
  • 特に変更がなく、急いで最新に上げる必要がない

ため、PRを取り下げます。
不具合が解消したらまた対応します。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uknmr uknmr uknmr approved these changes

@tosiiu tosiiu Awaiting requested review from tosiiu

@oremega oremega Awaiting requested review from oremega

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@drivesketch @oremega @uknmr