Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

モーダルなUIの基準 #1126

Merged
merged 41 commits into from May 20, 2024
Merged

モーダルなUIの基準 #1126

merged 41 commits into from May 20, 2024

Conversation

drivesketch
Copy link
Contributor

@drivesketch drivesketch commented Apr 15, 2024

課題・背景

モーダルなUIのデザインパターンを書きました。

やったこと

動作確認

Previewで見てね

https://deploy-preview-1126--smarthr-design-system.netlify.app/products/design-patterns/modal-ui/

キャプチャ

Before After

Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for smarthr-design-system ready!

Name Link
🔨 Latest commit f346e2e
🔍 Latest deploy log https://app.netlify.com/sites/smarthr-design-system/deploys/664aafa22c86c20008413105
😎 Deploy Preview https://deploy-preview-1126--smarthr-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@drivesketch drivesketch marked this pull request as ready for review April 15, 2024 21:57
Copy link
Contributor

@versionfive versionfive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

全体的に読みやすく内容も理解しやすかったです!
主に「こういうときにつかうとよい」という主張で書くようなコメントをしています。

ファイル構成ですが、ファイル移動に強い、以下がよいと思います。(ほかも整理したい…)

  • /components/modai-ui/
    • index.mdx
    • images/

content/articles/products/design-patterns/modal-ui.mdx Outdated Show resolved Hide resolved
content/articles/products/design-patterns/modal-ui.mdx Outdated Show resolved Hide resolved
content/articles/products/design-patterns/modal-ui.mdx Outdated Show resolved Hide resolved
content/articles/products/design-patterns/modal-ui.mdx Outdated Show resolved Hide resolved
content/articles/products/design-patterns/modal-ui.mdx Outdated Show resolved Hide resolved
content/articles/products/design-patterns/modal-ui.mdx Outdated Show resolved Hide resolved
content/articles/products/design-patterns/modal-ui.mdx Outdated Show resolved Hide resolved
content/articles/products/design-patterns/modal-ui.mdx Outdated Show resolved Hide resolved
content/articles/products/design-patterns/modal-ui.mdx Outdated Show resolved Hide resolved
content/articles/products/design-patterns/modal-ui.mdx Outdated Show resolved Hide resolved
drivesketch and others added 3 commits April 18, 2024 10:51
Co-authored-by: versionfive <64398878+versionfive@users.noreply.github.com>
Co-authored-by: versionfive <64398878+versionfive@users.noreply.github.com>
Co-authored-by: versionfive <64398878+versionfive@users.noreply.github.com>
Copy link
Contributor

@versionfive versionfive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あらためて全体をみてコメントしました

drivesketch and others added 4 commits May 9, 2024 15:34
Co-authored-by: versionfive <64398878+versionfive@users.noreply.github.com>
Co-authored-by: versionfive <64398878+versionfive@users.noreply.github.com>
Co-authored-by: versionfive <64398878+versionfive@users.noreply.github.com>
Co-authored-by: versionfive <64398878+versionfive@users.noreply.github.com>
Copy link
Contributor

@tosiiu tosiiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コメント2点しました!

tosiiu
tosiiu previously approved these changes May 17, 2024
Copy link
Contributor

@tosiiu tosiiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

versionfive
versionfive previously approved these changes May 17, 2024
Copy link
Contributor

@versionfive versionfive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!!!!

Copy link
Member

@MasafumiKabe MasafumiKabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一点だけ修正お願いします!その他はよさそう!

Co-authored-by: Masafumi Kabe <42249033+MasafumiKabe@users.noreply.github.com>
@drivesketch drivesketch dismissed stale reviews from versionfive and tosiiu via f346e2e May 20, 2024 02:04
Copy link
Member

@MasafumiKabe MasafumiKabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :arigatau:

@drivesketch
Copy link
Contributor Author

@tosiiu 文言修正したのでノールックで再度approveいただけますと 🙏

@drivesketch drivesketch merged commit 5de7bdf into main May 20, 2024
5 checks passed
@drivesketch drivesketch deleted the design-pattern_modal-ui_new branch May 20, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants