Sets policy as isPolicyUniqueReachable when the latest policy pod is ready. #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ereslibre
reviewed
Apr 5, 2022
ereslibre
requested changes
Apr 5, 2022
ereslibre
reviewed
Apr 6, 2022
raulcabello
reviewed
Apr 6, 2022
| verbs: | ||
| - get | ||
| - list | ||
| - watch |
There was a problem hiding this comment.
please don't forget to add this to the helm chart as well
raulcabello
reviewed
Apr 6, 2022
There was a problem hiding this comment.
I agree with @ereslibre comments. Apart from that it looks good to me. Thanks!
viccuad
approved these changes
Apr 6, 2022
Adds the permissions to allow the controller to access the replicaset resources.
…ready. Updates the code used to check if a policy is unique reachable only when the pods from the last policy server deployment replicaset are ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the code used to check if a policy is unique reachable only when the pods from the last policy server deployment replicaset are ready.