Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Do not commit generated files #983

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

akrejcir
Copy link
Collaborator

@akrejcir akrejcir commented May 9, 2024

What this PR does / why we need it:
This commit removes these generated files from the repository:

  • data/olm-catalog/ssp-operator.clusterserviceversion.yaml
  • data/crd/ssp.kubevirt.io_ssps.yaml

Instead of these files, the csv-generator uses the generated bundle directory.

This change will be useful in the future when we update operator-sdk, because then the generated files will contain a creation timestamp, which would be updated in every new PR.

Release note:

None

This commit removes these generated files from the repository:
- data/olm-catalog/ssp-operator.clusterserviceversion.yaml
- data/crd/ssp.kubevirt.io_ssps.yaml

Instead of these files, the csv-generator uses the generated
"bundle" directory.

Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 9, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from akrejcir. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akrejcir
Copy link
Collaborator Author

akrejcir commented May 9, 2024

/cc @ksimon1 @0xFelix @jcanocan

Copy link

sonarcloud bot commented May 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

openshift-ci bot commented May 9, 2024

@akrejcir: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unittests 8cd2c0a link true /test unittests
ci/prow/e2e-functests 8cd2c0a link true /test e2e-functests
ci/prow/e2e-upgrade-functests 8cd2c0a link true /test e2e-upgrade-functests
ci/prow/e2e-single-node-functests 8cd2c0a link true /test e2e-single-node-functests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants