[release-v0.18] fix: Remove namespaceSelector from webhook definition #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ValidatingWebhookConfiguration created by OLM can have namespaceSelector field set. We don't want that, because the webhook checks that there is only one SSP resource in the cluster. This commit adds a controller that watches ValidatingWebhookConfigurations and removes the namespaceSelector, if the object has a specific label. Cherry-pick fron: 948eeaa Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
kubevirt-bot
added
release-note-none
Some changes were needed from the PR in main branch. - "slices" package is not yet in go 1.19 - The "TypeMeta" needs to be defined in objects used in unit tests. - Do not use "k8s.io/utils/ptr" package. Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
akrejcir
force-pushed
the
webhook-namespace-selector-0.18
branch
from
eb15581
to
52995a8
Compare
|
|
Waiting for QE to confirm that we want this. /hold |
kubevirt-bot
added
the
do-not-merge/hold
|
QE wants this backport. /unhold |
kubevirt-bot
removed
the
do-not-merge/hold
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lyarwood The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of: #879
What this PR does / why we need it:
The
ValidatingWebhookConfigurationcreated by OLM can havenamespaceSelectorfield set. We don't want it, because the webhook checks that there is only one SSP resource in the cluster.Which issue(s) this PR fixes:
Jira: https://issues.redhat.com/browse/CNV-36636
Release note: