Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove tekton resources, if feature gate is set to 'false' #975

Closed
wants to merge 1 commit into from

Conversation

akrejcir
Copy link
Collaborator

What this PR does / why we need it:
Tekton resources are not created by ssp-operator anymore. If a user wants to remove existing old tekton resources, the feature gate can be set to false.

Which issue(s) this PR fixes:
Fixes: https://issues.redhat.com/browse/CNV-33012

Release note:

Feature gate "deployTektonTaskResources" can be set to "false" to remove existing old tekton resources.

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 30, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from akrejcir. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akrejcir
Copy link
Collaborator Author

/cc @ksimon1 @0xFelix

@akrejcir
Copy link
Collaborator Author

This PR needs to wait until HCO PR is merged: kubevirt/hyperconverged-cluster-operator#2921

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2024
Tekton resources are not created by ssp-operator anymore.
If a user wants to remove existing old tekton resources,
the feature gate can be set to 'false'.

Jira: https://issues.redhat.com/browse/CNV-33012

Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
Copy link

sonarcloud bot commented Apr 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

openshift-ci bot commented Apr 30, 2024

@akrejcir: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-upgrade-functests b69b00b link true /test e2e-upgrade-functests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akrejcir
Copy link
Collaborator Author

Closing because this will not be in 4.16. We will add documentation to explain how to remove old tekton resources.

/close

@kubevirt-bot
Copy link
Contributor

@akrejcir: Closed this PR.

In response to this:

Closing because this will not be in 4.16. We will add documentation to explain how to remove old tekton resources.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akrejcir akrejcir deleted the tekton-fg-cleanup branch May 14, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants