Fix common-instancetypes func tests with HCO

[lyarwood]

/cc @0xFelix

What this PR does / why we need it:

The functional tests currently assume that SSP is deployed standalone without HCO. However these same tests are also used downstream in a slightly different context where we initially deploy the environment using HCO. As such the common-instancetypes tests are invalid and need to be skipped. This series adds some limited coverage for this scenario ensuring that SSP ignores the virt-operator deployed resources.

More comprehensive coverage needs to be added to HCO to assert the default behaviour of virt-operator and ssp-operator in environments where HCO is still actively reconciling both.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Release note:

NONE

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lyarwood. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[lyarwood]

/retest-required

[0xFelix]

Not sure this is the right approach. Can't we make sure to set the appropriate FGs during the tests and reset them to their original value after the tests ran? The functionality is there and a user could still choose to enable it by modifying the FGs with jsonpatch annotations on HCO's CR.

Of course this won't work if HCO keeps reconciling them, but I don't think the test is at fault when HCO interferes with it.

[lyarwood]

Not sure this is the right approach. Can't we make sure to set the appropriate FGs during the tests and reset them to their original value after the tests ran? The functionality is there and a user could still choose to enable it by modifying the FGs with jsonpatch annotations on HCO's CR.

Of course this won't work if HCO keeps reconciling them, but I don't think the test is at fault when HCO interferes with it.

Yeah fair point, with HCO disabled we can just disable the KV FG for virt-operator deployment in a BeforeAll and restore in AfterAll. That should allow these tests to work regardless of HCO being involved in the initial deployment. I guess we should also wait for virt-operator to clean up these resources? Let me rework this.

/hold

[openshift-ci]

@lyarwood: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-upgrade-functests	a6bd686	link	true	/test e2e-upgrade-functests
ci/prow/e2e-single-node-functests	a6bd686	link	true	/test e2e-single-node-functests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.