Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.2] Fix kubevirt_memory_delta_from_requested_bytes label #11808

Merged
merged 1 commit into from
May 3, 2024
Merged

[release-1.2] Fix kubevirt_memory_delta_from_requested_bytes label #11808

merged 1 commit into from
May 3, 2024

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #11794

/assign avlitman

none

@avlitman
Fix kubevirt_memory_delta_from_requested label
4563ac4 
Fix kubevirt_memory_delta_from_requested_bytes reason label to contain
`_delta_from_requested_bytes` suffix.

Signed-off-by: avlitman <alitman@redhat.com>
@kubevirt-bot kubevirt-bot mentioned this pull request Apr 27, 2024
Merged
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 27, 2024
@sradco
Copy link
Contributor

sradco commented Apr 30, 2024

/approve

@avlitman
Copy link
Contributor

/approve

can't approve yet since #11705 is not merged.

@avlitman
Copy link
Contributor

@enp0s3 Hi this is a cherry pick for a merged pr. can you take a look and approve ?(:

@sradco
Copy link
Contributor

sradco commented May 1, 2024

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 1, 2024
@enp0s3
Copy link
Contributor

enp0s3 commented May 2, 2024

/approve

@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enp0s3, sradco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2024
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

2 similar comments
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot
Copy link
Contributor Author

kubevirt-bot commented May 3, 2024 •
edited

@kubevirt-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-goveralls 4563ac4 link false /test pull-kubevirt-goveralls-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubevirt-bot kubevirt-bot merged commit 4bf4d6c into kubevirt:release-1.2 May 3, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdDev EdDev Awaiting requested review from EdDev

@victortoso victortoso Awaiting requested review from victortoso

Assignees

@sradco sradco

@avlitman avlitman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/monitoring dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kubevirt-bot @sradco @avlitman @enp0s3 @kubevirt-commenter-bot