Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.2] sig-observability: Update ownerships #11705

Merged
merged 3 commits into from
May 1, 2024
Merged

[release-1.2] sig-observability: Update ownerships #11705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13947e9
Add sig-observability approvers/reviewers to monitoring packages
machadovilaca Feb 14, 2024
da62f9d
Add machadovilaca to sig-observability-reviewers
machadovilaca Feb 14, 2024
9845584
Add sradco to sig-observability-approvers
machadovilaca Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions OWNERS_ALIASES
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,10 @@ aliases:
# Owns the responsibility to keep kubevirt observable by i.e.
# having mertics, alters, and runbooks.
#
sig-observability-approvers: []
sig-observability-reviewers: []
sig-observability-approvers:
- sradco
sig-observability-reviewers:
- machadovilaca

#
# SIG Release
Expand Down
8 changes: 8 additions & 0 deletions hack/prom-rule-ci/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# See the OWNERS docs at https://go.k8s.io/owners

approvers:
- sig-observability-approvers
reviewers:
- sig-observability-reviewers
labels:
- sig/observability
10 changes: 6 additions & 4 deletions pkg/monitoring/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# See the OWNERS docs at https://go.k8s.io/owners

filters:
".*":
labels:
- area/monitoring
approvers:
- sig-observability-approvers
reviewers:
- sig-observability-reviewers
labels:
- sig/observability
8 changes: 8 additions & 0 deletions tests/libmonitoring/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# See the OWNERS docs at https://go.k8s.io/owners

approvers:
- sig-observability-approvers
reviewers:
- sig-observability-reviewers
labels:
- sig/observability
8 changes: 8 additions & 0 deletions tests/monitoring/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# See the OWNERS docs at https://go.k8s.io/owners

approvers:
- sig-observability-approvers
reviewers:
- sig-observability-reviewers
labels:
- sig/observability