Apply monitoring linters

[assafad]

What this PR does

Apply the following linters:

• monitoringlinter that was implemented in Add monitoring linter monitoring#221, and was designed to enforce proposal: Monitoring code refactor community#219.
  This linter ensures that all monitoring-related practices are implemented within the pkg/monitoring directory using operator-observability methods. It verifies that all metrics, alerts and recording rules registrations are centralized in this directory, and restricts the direct use of Prometheus registration methods.
  Example for a message reported by the linter:

  kubevirt/pkg/virt-controller/watch/workload-updater/workload-updater.go:67:2: monitoring-linter: metrics should be registered only within pkg/monitoring directory, using operator-observability packages.
  

• operator-observability rules linter - ensures that alerts and recording rules definitions are following the monitoring best practices, e.g. alerts have all the required annotations and labels with expected values, recording rules have expressions, etc. In addition, bump operator-observability for it.

Fixes https://issues.redhat.com/browse/CNV-36761

Special notes for your reviewer:

Depending on #11184 and https://issues.redhat.com/browse/CNV-39013.

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

• Design: A design document was considered and is present (link) or not required
• PR: The PR description is expressive enough and will help future contributors
• Code: Write code that humans can understand and Keep it simple
• Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
• Upgrade: Impact of this change on upgrade flows was considered and addressed if required
• Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
• Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
• Community: Announcement to kubevirt-dev was considered

Release note

None

[kubevirt-bot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[assafad]

Since the monitoring refactoring is still WIP (should be completed by #11184 and https://issues.redhat.com/browse/CNV-39013), currently the monitoring linter gives:

monitoringlinter ./pkg/...
/root/go/src/kubevirt.io/kubevirt/pkg/monitoring/client/prometheus/prometheus.go:95:2: monitoring-linter: metrics should be registered only within pkg/monitoring directory, using operator-observability packages.
/root/go/src/kubevirt.io/kubevirt/pkg/monitoring/client/prometheus/prometheus.go:96:2: monitoring-linter: metrics should be registered only within pkg/monitoring directory, using operator-observability packages.
/root/go/src/kubevirt.io/kubevirt/pkg/monitoring/client/prometheus/prometheus.go:97:2: monitoring-linter: metrics should be registered only within pkg/monitoring directory, using operator-observability packages.
/root/go/src/kubevirt.io/kubevirt/pkg/monitoring/domainstats/prometheus/prometheus.go:584:2: monitoring-linter: metrics should be registered only within pkg/monitoring directory, using operator-observability packages.
/root/go/src/kubevirt.io/kubevirt/pkg/monitoring/reflector/prometheus/prometheus.go:79:2: monitoring-linter: metrics should be registered only within pkg/monitoring directory, using operator-observability packages.
/root/go/src/kubevirt.io/kubevirt/pkg/monitoring/reflector/prometheus/prometheus.go:80:2: monitoring-linter: metrics should be registered only within pkg/monitoring directory, using operator-observability packages.
/root/go/src/kubevirt.io/kubevirt/pkg/monitoring/reflector/prometheus/prometheus.go:81:2: monitoring-linter: metrics should be registered only within pkg/monitoring directory, using operator-observability packages.
/root/go/src/kubevirt.io/kubevirt/pkg/monitoring/reflector/prometheus/prometheus.go:82:2: monitoring-linter: metrics should be registered only within pkg/monitoring directory, using operator-observability packages.
/root/go/src/kubevirt.io/kubevirt/pkg/monitoring/reflector/prometheus/prometheus.go:83:2: monitoring-linter: metrics should be registered only within pkg/monitoring directory, using operator-observability packages.
/root/go/src/kubevirt.io/kubevirt/pkg/monitoring/reflector/prometheus/prometheus.go:84:2: monitoring-linter: metrics should be registered only within pkg/monitoring directory, using operator-observability packages.
/root/go/src/kubevirt.io/kubevirt/pkg/monitoring/reflector/prometheus/prometheus.go:85:2: monitoring-linter: metrics should be registered only within pkg/monitoring directory, using operator-observability packages.
/root/go/src/kubevirt.io/kubevirt/pkg/monitoring/reflector/prometheus/prometheus.go:86:2: monitoring-linter: metrics should be registered only within pkg/monitoring directory, using operator-observability packages.
/root/go/src/kubevirt.io/kubevirt/pkg/monitoring/workqueue/prometheus/prometheus.go:54:2: monitoring-linter: metrics should be registered only within pkg/monitoring directory, using operator-observability packages.
/root/go/src/kubevirt.io/kubevirt/pkg/monitoring/workqueue/prometheus/prometheus.go:66:2: monitoring-linter: metrics should be registered only within pkg/monitoring directory, using operator-observability packages.
/root/go/src/kubevirt.io/kubevirt/pkg/monitoring/workqueue/prometheus/prometheus.go:79:2: monitoring-linter: metrics should be registered only within pkg/monitoring directory, using operator-observability packages.
/root/go/src/kubevirt.io/kubevirt/pkg/monitoring/workqueue/prometheus/prometheus.go:92:2: monitoring-linter: metrics should be registered only within pkg/monitoring directory, using operator-observability packages.
/root/go/src/kubevirt.io/kubevirt/pkg/monitoring/workqueue/prometheus/prometheus.go:104:2: monitoring-linter: metrics should be registered only within pkg/monitoring directory, using operator-observability packages.
/root/go/src/kubevirt.io/kubevirt/pkg/monitoring/workqueue/prometheus/prometheus.go:117:2: monitoring-linter: metrics should be registered only within pkg/monitoring directory, using operator-observability packages.
/root/go/src/kubevirt.io/kubevirt/pkg/monitoring/workqueue/prometheus/prometheus.go:132:2: monitoring-linter: metrics should be registered only within pkg/monitoring directory, using operator-observability packages.
/root/go/src/kubevirt.io/kubevirt/pkg/virt-controller/watch/workload-updater/workload-updater.go:67:2: monitoring-linter: metrics should be registered only within pkg/monitoring directory, using operator-observability packages.
make: *** [Makefile:225: lint] Error 1

[iholder101]

General direction seems great to me.
Thanks for your efforts @assafad! Great work!

/approve

However, since I'm not familiar with all of the details, I'd like others that were involved to have a look and have time to give feedback. Let's hold the PR until the involved people review.

/hold

@sradco @machadovilaca @nunnatsa @RamLavi - would you be able to review?
FYI @enp0s3 @vladikr

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iholder101

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [iholder101]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[victortoso]

I'd suggest adding in the Special notes for your reviewer: of the first comment this PR depends on kubevirt/community#219 #11184 (and others?) and moving it to Draft while those dependencies don't get merged.

[kubevirt-bot]

@assafad: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubevirt-generate	c8ceea1	link	true	/test pull-kubevirt-generate
pull-kubevirt-verify-go-mod	c8ceea1	link	true	/test pull-kubevirt-verify-go-mod
pull-kubevirt-prom-rules-verify	c8ceea1	link	true	/test pull-kubevirt-prom-rules-verify
pull-kubevirt-code-lint	c8ceea1	link	true	/test pull-kubevirt-code-lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.