Apply monitoringlinter (#1771)

Apply monitoringlinter, which is designed to enforce
kubevirt/community#219 by ensuring that monitoring-related practices are
implemented within the pkg/monitoring directory using
operator-observability methods.

Signed-off-by: assafad <aadmi@redhat.com>

Makefile

@@ -49,6 +49,8 @@ GITHUB_RELEASE ?= $(BIN_DIR)/github-release
 
 CONTROLLER_GEN ?= $(BIN_DIR)/controller-gen
 
+MONITORING_LINTER ?= $(BIN_DIR)/monitoringlinter
+
 GO := $(GOBIN)/go
 
 $(GO):
@@ -214,6 +216,9 @@ generate-doc:
 lint-metrics:
 	./hack/prom_metric_linter.sh --operator-name="kubevirt" --sub-operator-name="cnao"
 
+lint-monitoring:
+	GOBIN=$$(pwd)/build/_output/bin/ $(GO) install -mod=mod github.com/kubevirt/monitoring/monitoringlinter/cmd/monitoringlinter@e2be790
+	$(MONITORING_LINTER) ./...
 
 .PHONY: \
 	$(E2E_SUITES) \
@@ -248,5 +253,6 @@ lint-metrics:
 	prom-rules-verify \
 	release \
 	update-workflows-branches \
-	statify-components
+	statify-components \
+	lint-monitoring
 

automation/check-patch.unit-test.sh

@@ -16,6 +16,7 @@ main() {
     make check
     verify_metrics_docs_updated
     make lint-metrics
+    make lint-monitoring
     make docker-build
 }