Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query workspace users with groupbindings #4633

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RolandMa1986
Copy link
Member

Signed-off-by: Roland.Ma rolandma@kubesphere.io

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

Include users that are added to the Workspace through the Group when querying users by workspace.

Which issue(s) this PR fixes:

Fixes #4630

Special notes for reviewers:

Does this PR introduced a user-facing change?

Users that are invited to Workspace Group will be included when querying users by workspace.

Additional documentation, usage docs, etc.:


Signed-off-by: Roland.Ma <rolandma@kubesphere.io>
@ks-ci-bot ks-ci-bot added release-note kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Jan 19, 2022
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RolandMa1986
To complete the pull request process, please assign wansir after the PR has been reviewed.
You can assign the PR to them by writing /assign @wansir in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 19, 2022
@RolandMa1986
Copy link
Member Author

/cc @wansir

@ks-ci-bot ks-ci-bot requested a review from wansir January 20, 2022 02:21
@wansir
Copy link
Member

wansir commented Jan 25, 2022

/hold

There are some differences between workspace member management and organizational management. How to remove the organization member from the workspace member list if we mixed the two parts. I think a query condition should be used to filter the kind of workspace member, distinguish the entry of member management and organization management.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. release-note size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users that are invited to the Workspace through Group should also be able to invite to Project
3 participants