New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [WIP] Add admission policy management APIs #4260
base: master
Are you sure you want to change the base?
Conversation
Hi @sagilio. Thanks for your PR. I'm waiting for a kubesphere member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #4260 +/- ##
==========================================
- Coverage 28.64% 28.55% -0.09%
==========================================
Files 221 221
Lines 22457 22451 -6
==========================================
- Hits 6433 6412 -21
- Misses 14962 14978 +16
+ Partials 1062 1061 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Sagilio <Sagilio@outlook.com>
@sagilio Please use |
37f5b89
to
3e9b961
Compare
a329d5f
to
9112190
Compare
f55c536
to
a70396e
Compare
Signed-off-by: Sagilio <Sagilio@outlook.com>
25c617b
to
aa69927
Compare
Signed-off-by: Sagilio <Sagilio@outlook.com>
/assign @wansir |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sagilio The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: sagilio <sagilio@outlook.com> # Conflicts: # Makefile # go.mod # pkg/apiserver/config/config.go # pkg/client/listers/types/v1beta1/federatedresourcequota.go # vendor/modules.txt
@sagilio: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Sagilio Sagilio@outlook.com
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
Proposal #4139
Which issue(s) this PR fixes:
Fixes #4259
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: