Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [WIP] Add admission policy management APIs #4260

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sagilio
Copy link

@sagilio sagilio commented Sep 20, 2021

Signed-off-by: Sagilio Sagilio@outlook.com

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

Proposal #4139

Which issue(s) this PR fixes:

Fixes #4259

Special notes for reviewers:

Now, this feature is working in progress, I will update the docs on issue #4259 later.

Does this PR introduced a user-facing change?

Add admission policy management APIs

Additional documentation, usage docs, etc.:


@ks-ci-bot ks-ci-bot added release-note do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API needs-ok-to-test size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 20, 2021
@ks-ci-bot
Copy link
Collaborator

Hi @sagilio. Thanks for your PR.

I'm waiting for a kubesphere member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #4260 (fe52e50) into master (cc57b61) will decrease coverage by 0.08%.
The diff coverage is n/a.

❗ Current head fe52e50 differs from pull request most recent head 6b2af45. Consider uploading reports for the commit 6b2af45 to get more accurate results

@@            Coverage Diff             @@
##           master    #4260      +/-   ##
==========================================
- Coverage   28.64%   28.55%   -0.09%     
==========================================
  Files         221      221              
  Lines       22457    22451       -6     
==========================================
- Hits         6433     6412      -21     
- Misses      14962    14978      +16     
+ Partials     1062     1061       -1     
Flag Coverage Δ
unittests 28.55% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ller/destinationrule/destinationrule_controller.go 36.81% <0.00%> (-10.00%) ⬇️
...rix/helmapplication/helm_application_controller.go 51.23% <0.00%> (-3.31%) ⬇️
...controller/groupbinding/groupbinding_controller.go 62.67% <0.00%> (-2.12%) ⬇️
...application/helm_application_version_controller.go 68.99% <0.00%> (-1.56%) ⬇️
...roller/storage/capability/capability_controller.go 36.44% <0.00%> (-1.52%) ⬇️
pkg/controller/user/user_controller.go 25.53% <0.00%> (-0.19%) ⬇️
pkg/controller/network/ippool/ippool_controller.go 41.57% <0.00%> (+0.71%) ⬆️
pkg/models/gateway/gateway.go 68.52% <0.00%> (+1.85%) ⬆️
...g/controller/application/application_controller.go 71.03% <0.00%> (+3.44%) ⬆️
.../storage/snapshotclass/snapshotclass_controller.go 47.12% <0.00%> (+5.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c2a419...6b2af45. Read the comment docs.

Signed-off-by: Sagilio <Sagilio@outlook.com>
@ks-ci-bot ks-ci-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 26, 2021
@wansir
Copy link
Member

wansir commented Sep 29, 2021

@sagilio Please use ./hack/update-gofmt.sh, ./hack/update-goimports.sh format the code.

@sagilio sagilio force-pushed the fix#4259 branch 2 times, most recently from 37f5b89 to 3e9b961 Compare October 6, 2021 21:08
@ks-ci-bot ks-ci-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 6, 2021
@sagilio sagilio force-pushed the fix#4259 branch 2 times, most recently from a329d5f to 9112190 Compare October 10, 2021 20:30
@sagilio sagilio force-pushed the fix#4259 branch 2 times, most recently from f55c536 to a70396e Compare October 10, 2021 22:41
Signed-off-by: Sagilio <Sagilio@outlook.com>
@sagilio sagilio force-pushed the fix#4259 branch 2 times, most recently from 25c617b to aa69927 Compare October 14, 2021 01:59
Signed-off-by: Sagilio <Sagilio@outlook.com>
@sagilio
Copy link
Author

sagilio commented Nov 17, 2021

/assign @wansir

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sagilio
To complete the pull request process, please ask for approval from wansir after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: sagilio <sagilio@outlook.com>

# Conflicts:
#	Makefile
#	go.mod
#	pkg/apiserver/config/config.go
#	pkg/client/listers/types/v1beta1/federatedresourcequota.go
#	vendor/modules.txt
@ks-ci-bot
Copy link
Collaborator

@sagilio: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test needs-rebase release-note size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add admission policy management APIs
3 participants