Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration porter #3314

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Integration porter #3314

wants to merge 1 commit into from

Conversation

duanjiong
Copy link
Member

Signed-off-by: Duan Jiong djduanjiong@gmail.com

What type of PR is this?

/kind feature

What this PR does / why we need it:

Integration porter on web UI, and update vendor

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Additional documentation, usage docs, etc.:


Signed-off-by: Duan Jiong <djduanjiong@gmail.com>
@ks-ci-bot ks-ci-bot added kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes labels Jan 27, 2021
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: duanjiong
To complete the pull request process, please assign zryfish
You can assign the PR to them by writing /assign @zryfish in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 27, 2021
@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Patch coverage: 18.66% and no project coverage change.

Comparison is base (38eaa5c) 11.42% compared to head (f35d5b3) 11.42%.
Report is 1063 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3314   +/-   ##
=======================================
  Coverage   11.42%   11.42%           
=======================================
  Files         225      228    +3     
  Lines       42354    42424   +70     
=======================================
+ Hits         4837     4848   +11     
- Misses      36771    36825   +54     
- Partials      746      751    +5     
Flag Coverage Δ
unittests 11.42% <18.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/apiserver/config/config.go 23.30% <0.00%> (-1.70%) ⬇️
pkg/controller/network/ippool/ippool_controller.go 55.44% <0.00%> (-0.29%) ⬇️
pkg/models/resources/v1alpha3/porter/bgpconf.go 0.00% <0.00%> (ø)
pkg/models/resources/v1alpha3/porter/bgppeer.go 0.00% <0.00%> (ø)
...kg/simple/client/network/ippool/calico/provider.go 7.14% <0.00%> (-0.09%) ⬇️
pkg/models/resources/v1alpha3/porter/eip.go 45.83% <45.83%> (ø)
pkg/models/resources/v1alpha3/resource/resource.go 88.13% <100.00%> (+0.63%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@duanjiong
Copy link
Member Author

/hold

@swiftslee
Copy link
Contributor

@duanjiong
Are we going to integrate porter in v3.1.0?

@duanjiong
Copy link
Member Author

duanjiong commented Apr 13, 2021

@duanjiong
Are we going to integrate porter in v3.1.0?

No, just ignore this pr

@ks-ci-bot
Copy link
Collaborator

@duanjiong: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes do-not-merge/hold kind/feature Categorizes issue or PR as related to a new feature. needs-rebase size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants