New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add kubeovn api #3208
base: master
Are you sure you want to change the base?
feature: add kubeovn api #3208
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fafucoder The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3208 +/- ##
==========================================
+ Coverage 11.06% 11.12% +0.06%
==========================================
Files 219 219
Lines 42048 42053 +5
==========================================
+ Hits 4652 4680 +28
+ Misses 36677 36655 -22
+ Partials 719 718 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
I don't think that's appropriate. This pr strongly couples kubeovn, a cni plugin, to kubesphere, and we should abstract its capabilities to an intermediate layer, so that subsequent adaptations to other plugins will be more elegant |
/cc @zheng1 |
For example, if you integrate the subnet management function of kube-ovn here, the ippool crd is included in the kubesphere, and you only need to implement the corresponding ippool provider accordingly. For details, please refer to https://github.com/kubesphere/community/blob/master/sig-network/concepts-and-designs/ippool.md |
Abstract an intermediate layer is not easy, different cni have a different api definition. The kuveovn has provided subnet and ip api, I don't think it's necessary to abstract a middle layer. |
We have updated the version of client-go, please fix the conflict in this PR |
/lgtm |
Signed-off-by: linruichao <linruichao@ruijie.com.cn>
New changes are detected. LGTM label has been removed. |
@fafucoder: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: linruichao linruichao@ruijie.com.cn
What type of PR is this?
/kind feature
What this PR does / why we need it:
add kubeovn api as the console can request it , the front web page like this.
Additional documentation, usage docs, etc.: