Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add kubeovn api #3208

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

fafucoder
Copy link
Contributor

@fafucoder fafucoder commented Dec 16, 2020

Signed-off-by: linruichao linruichao@ruijie.com.cn

What type of PR is this?
/kind feature

What this PR does / why we need it:
add kubeovn api as the console can request it , the front web page like this.
image

Additional documentation, usage docs, etc.:

https://github.com/alauda/kube-ovn

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fafucoder
To complete the pull request process, please assign zryfish
You can assign the PR to them by writing /assign @zryfish in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 16, 2020
@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Patch coverage: 60.00% and project coverage change: +0.06% 🎉

Comparison is base (2e9b42e) 11.06% compared to head (ba03b76) 11.12%.
Report is 1074 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3208      +/-   ##
==========================================
+ Coverage   11.06%   11.12%   +0.06%     
==========================================
  Files         219      219              
  Lines       42048    42053       +5     
==========================================
+ Hits         4652     4680      +28     
+ Misses      36677    36655      -22     
+ Partials      719      718       -1     
Flag Coverage Δ
unittests 11.12% <60.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/apiserver/query/types.go 69.04% <ø> (ø)
pkg/apiserver/config/config.go 25.25% <33.33%> (+0.25%) ⬆️
pkg/models/resources/v1alpha3/resource/resource.go 87.71% <100.00%> (+0.44%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ks-ci-bot ks-ci-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 16, 2020
@duanjiong
Copy link
Member

I don't think that's appropriate. This pr strongly couples kubeovn, a cni plugin, to kubesphere, and we should abstract its capabilities to an intermediate layer, so that subsequent adaptations to other plugins will be more elegant

@duanjiong
Copy link
Member

/cc @zheng1

@ks-ci-bot ks-ci-bot requested a review from zheng1 January 6, 2021 12:08
@duanjiong
Copy link
Member

For example, if you integrate the subnet management function of kube-ovn here, the ippool crd is included in the kubesphere, and you only need to implement the corresponding ippool provider accordingly. For details, please refer to https://github.com/kubesphere/community/blob/master/sig-network/concepts-and-designs/ippool.md

@fafucoder
Copy link
Contributor Author

I don't think that's appropriate. This pr strongly couples kubeovn, a cni plugin, to kubesphere, and we should abstract its capabilities to an intermediate layer, so that subsequent adaptations to other plugins will be more elegant

Abstract an intermediate layer is not easy, different cni have a different api definition. The kuveovn has provided subnet and ip api, I don't think it's necessary to abstract a middle layer.

@zheng1
Copy link
Member

zheng1 commented Jan 13, 2021

We have updated the version of client-go, please fix the conflict in this PR

pkg/apiserver/apiserver.go Outdated Show resolved Hide resolved
@zheng1
Copy link
Member

zheng1 commented Jan 19, 2021

/lgtm
/cc @zryfish

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2021
Signed-off-by: linruichao <linruichao@ruijie.com.cn>
@ks-ci-bot ks-ci-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2021
@ks-ci-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@ks-ci-bot
Copy link
Collaborator

@fafucoder: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes kind/feature Categorizes issue or PR as related to a new feature. needs-rebase size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants