feat: custom popup for displaying editor schemas #2049
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olensmar
commented
Jul 5, 2022
src/hooks/useResourceYamlSchema.ts
Outdated
| path: schemaPath, | ||
| content: JSON.stringify(resourceSchema, null, 2), | ||
| }); | ||
| schemaUri = `http://localhost:51038${schemaPath}`; |
There was a problem hiding this comment.
port is hardcoded - need to get the actual port from the server
olensmar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts a local server for hosting custom schemas requested by the editor. The server is started in a worker window - which could be expanded for further async-processing later on.
The main (only?) drawback with this approach is that the user will be prompted to allow local network connections when the server starts the first time (which it does lazily as needed - which might be never for many users...).
Checklist