Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve note for the Job managedBy feature #45506

Merged
merged 2 commits into from Mar 12, 2024
Merged

Improve note for the Job managedBy feature #45506

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a7baf4
Improve note for Job managedBy feature
mimowo Mar 11, 2024
5bc7082
Make feature gate date driven
mimowo Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions content/en/docs/concepts/workloads/controllers/job.md
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional improvement in Line 1011 ({{< feature-state for_k8s_version="v1.30" state="alpha" >}}) to leverage the new feature_gate_name option, making the feature state more data-driven.

- {{< feature-state for_k8s_version="v1.30" state="alpha" >}}
+ {{< feature-state feature_gate_name="JobManagedBy" >}}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me try it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, PTAL

Expand Up @@ -1033,8 +1033,8 @@ When developing an external Job controller be aware that your controller needs
to operate in a fashion conformant with the definitions of the API spec and
status fields of the Job object.

Please review these in detail the [Job API](/docs/reference/kubernetes-api/workload-resources/job-v1/).
We also recommend you running the e2e conformance tests for the Job object to
Please review these in detail in the [Job API](/docs/reference/kubernetes-api/workload-resources/job-v1/).
We also recommend that you run the e2e conformance tests for the Job object to
verify your implementation.

Finally, when developing an external Job controller make sure it does not use the
Expand Down