Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRA in Kubernetes 1.30: adds structured parameters #45287

Merged
merged 1 commit into from Apr 12, 2024
Merged

DRA in Kubernetes 1.30: adds structured parameters #45287

merged 1 commit into from Apr 12, 2024

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Feb 22, 2024

No description provided.

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 22, 2024
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 22, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 22, 2024 •
edited

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit f4972cb
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/65f0909231ad1f00080d63d8

This was referenced Feb 22, 2024
Open
Open
@sftim
Copy link
Contributor

sftim commented Feb 22, 2024

/retitle [WIP] Update docs about DRA for Kubernetes 1.30

@k8s-ci-robot k8s-ci-robot changed the title DRA: Kubernetes 1.30 [WIP] Update docs about DRA for Kubernetes 1.30 Feb 22, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 22, 2024
@drewhagen
Copy link
Member

Hello @pohly 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday March 12th 2024 18:00 PST. Thank you!

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 8, 2024
@pohly pohly changed the title [WIP] Update docs about DRA for Kubernetes 1.30 DRA in Kubernetes 1.30: adds structured parameters Mar 8, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 8, 2024
pohly
pohly commented Mar 8, 2024
View reviewed changes
content/en/docs/concepts/scheduling-eviction/dynamic-resource-allocation.md Outdated
@@ -9,13 +9,15 @@ weight: 65

<!-- overview -->

{{< feature-state for_k8s_version="v1.27" state="alpha" >}}
{{< feature-state for_k8s_version="v1.26" state="alpha" >}}
{{< feature-state for_k8s_version="v1.30" state="alpha" >}}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what to document here: the first time this became available (1.26), the current status, or both?

If we include the current status, we have to refresh the version on each release. This had not been done for 1.28 and 1.29 because there were no other changes.

I had bumped the version from 1.26 to 1.27 because of the API change, but I am no longer sure whether that was the right thing to do, so I am going back to 1.26 here.

klueska
klueska reviewed Mar 8, 2024
View reviewed changes
content/en/docs/concepts/scheduling-eviction/dynamic-resource-allocation.md Outdated
Comment on lines 17 to 21
responsible for tracking and allocating resources. Different kinds of
resources support arbitrary parameters for defining requirements and
responsible for tracking and allocating resources, with additional support
provided by Kubernetes via "structured parameters" (introduced in Kubernetes 1.30).
Different kinds of resources support arbitrary parameters for defining requirements and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should expand on the distinction here a bit more in the intro.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added one sentence:

When a driver uses structured parameters, Kubernetes handles scheduling
and resource allocation without having to communicate with the driver.

sftim
sftim reviewed Mar 8, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review

content/en/docs/concepts/scheduling-eviction/dynamic-resource-allocation.md Outdated Show resolved Hide resolved
sftim
sftim reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs, one nit

content/en/docs/concepts/scheduling-eviction/dynamic-resource-allocation.md Outdated
responsible for tracking and allocating resources. Different kinds of
resources support arbitrary parameters for defining requirements and
responsible for tracking and allocating resources, with additional support
provided by Kubernetes via "structured parameters" (introduced in Kubernetes 1.30).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
provided by Kubernetes via "structured parameters" (introduced in Kubernetes 1.30).
provided by Kubernetes via _structured parameters_ (introduced in Kubernetes 1.30).

Please also consider adding “structured parameter” into our glossary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied your suggestion and squashed (forgot that earlier).

I'll keep the glossary in mind for the next update. Right now I feel it's too early - we still need to find out whether the name and concept survives.

@pohly
dra: update for Kubernetes 1.30
f4972cb 
Structured parameters are new in Kubernetes 1.30.
@reylejano
Copy link
Member

related to enhancement issue on DRA: structured parameters and KEP-4381 Structured Parameters for Dynamic Resource Allocation
/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Apr 12, 2024
@reylejano
Copy link
Member

/assign @drewhagen

@reylejano
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f3655726d3a818e0ab55962ad434c0188c833ae0

@reylejano
Copy link
Member

/milestone 1.30

@k8s-ci-robot k8s-ci-robot added this to the 1.30 milestone Apr 12, 2024
@drewhagen
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: drewhagen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0d1aa27 into kubernetes:dev-1.30 Apr 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klueska klueska klueska left review comments

@sftim sftim sftim left review comments

@mengjiao-liu mengjiao-liu Awaiting requested review from mengjiao-liu

Assignees

@drewhagen drewhagen

@reylejano reylejano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
1.30 Enhancements Tracking
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pohly @sftim @drewhagen @reylejano @k8s-ci-robot @klueska