Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for Job managedBy field (alpha) #45132

Merged
merged 4 commits into from Mar 11, 2024
Merged

Add docs for Job managedBy field (alpha) #45132

merged 4 commits into from Mar 11, 2024

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented Feb 14, 2024 •
edited

Enhancement tracking: kubernetes/enhancements#4368

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 14, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 14, 2024 •
edited

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 6b1afc2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/65eb3eb718ecb300082c8f3f

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 14, 2024
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Feb 14, 2024
@mimowo mimowo mentioned this pull request Feb 14, 2024
Open
8 tasks
@sftim
Copy link
Contributor

sftim commented Feb 14, 2024

/retitle [WIP] Add docs for Job managed-by label

@k8s-ci-robot k8s-ci-robot changed the title Add placeholder for job managed-by label docs [placeholder] [WIP] Add docs for Job managed-by label Feb 14, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 14, 2024
@sftim
Copy link
Contributor

sftim commented Feb 14, 2024

/sig apps

@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Feb 14, 2024
@mimowo mimowo mentioned this pull request Feb 15, 2024
Merged
@reylejano
Copy link
Member

/milestone 1.30

@k8s-ci-robot k8s-ci-robot added this to the 1.30 milestone Feb 16, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 6, 2024
@mimowo mimowo changed the title [WIP] Add docs for Job managed-by label Add docs for Job managedBy field (alpha) Mar 6, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2024
@mimowo
Copy link
Contributor Author

mimowo commented Mar 6, 2024

/cc @atiratree @alculquicondor
For review from technical / sig point of view.

@alculquicondor
Copy link
Member

/lgtm
as job approver

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8a21e3d23357fd041da2ef0b98a3ca123977e8a3

atiratree
atiratree reviewed Mar 11, 2024
View reviewed changes
content/en/docs/concepts/workloads/controllers/job.md
Comment on lines +1036 to +1038
Please review these in detail the [Job API](/docs/reference/kubernetes-api/workload-resources/job-v1/).
We also recommend you running the e2e conformance tests for the Job object to
verify your implementation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Please review these in detail the [Job API](/docs/reference/kubernetes-api/workload-resources/job-v1/).
We also recommend you running the e2e conformance tests for the Job object to
verify your implementation.
Please review these in detail in the [Job API](/docs/reference/kubernetes-api/workload-resources/job-v1/).
We also recommend that you run the e2e conformance tests for the Job object to
verify your implementation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was too slow to handle that. @atiratree do you think these are important enough for follow up PR, or just let it stay as is?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mimowo I would prefer an update if you agree that these formulations sound a bit off. I am not saying my version is the best though, so I will leave the final version up to you..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both suggestions are slightly better than original form so let me open the PR, we will see if other folks have other proposals there

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow up: #45506

@sftim
Copy link
Contributor

sftim commented Mar 11, 2024

I think this is OK to merge, and we welcome further PRs with polish (either for v1.30, or for the move to beta).

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7275d2c into kubernetes:dev-1.30 Mar 11, 2024
6 checks passed
@mimowo mimowo mentioned this pull request Mar 11, 2024
Merged
@drewhagen
Copy link
Member

/milestone 1.30

@k8s-ci-robot k8s-ci-robot added this to the 1.30 milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@atiratree atiratree atiratree left review comments

@dipesh-rawat dipesh-rawat Awaiting requested review from dipesh-rawat

@reylejano reylejano Awaiting requested review from reylejano

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Apps
Archived in project
Milestone
1.30
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mimowo @sftim @reylejano @alculquicondor @k8s-ci-robot @drewhagen @atiratree