Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable BlockVolume tests in gce and gke alpha suites #6998

Merged
merged 1 commit into from
Feb 26, 2018

Conversation

msau42
Copy link
Member

@msau42 msau42 commented Feb 26, 2018

There were many autogenerated configs that I did not modify. How do I update those?

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 26, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 26, 2018
@msau42
Copy link
Member Author

msau42 commented Feb 26, 2018

Also updated the auto generated configs

@krzyzacy
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzyzacy, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2018
@msau42
Copy link
Member Author

msau42 commented Feb 26, 2018

Problem with some internal script?

W0226 18:53:18.352] Run: ('./hack/verify-bazel.sh',)
W0226 18:53:30.891] # github.com/bazelbuild/bazel-gazelle/internal/merger
W0226 18:53:30.892] ../../internal/merger/fix.go:93:28: too few values in struct initializer
W0226 18:53:30.892] ../../internal/merger/merger.go:657:16: too few values in struct initializer
W0226 18:53:30.892] ../../internal/merger/merger.go:677:19: too few values in struct initializer
W0226 18:53:30.893] ../../internal/merger/merger.go:681:19: too few values in struct initializer
W0226 18:53:31.063] # github.com/bazelbuild/bazel-gazelle/internal/rules
W0226 18:53:31.063] ../../internal/rules/generator.go:183:16: too few values in struct initializer
W0226 18:53:31.064] ../../internal/rules/sort_labels.go:45:16: too few values in struct initializer
W0226 18:53:31.068] Traceback (most recent call last):
W0226 18:53:31.069]   File "/workspace/./test-infra/jenkins/../scenarios/execute.py", line 50, in <module>
W0226 18:53:31.069]     main(ARGS.env, ARGS.cmd + ARGS.args)
W0226 18:53:31.069]   File "/workspace/./test-infra/jenkins/../scenarios/execute.py", line 41, in main
W0226 18:53:31.069]     check(*cmd)
W0226 18:53:31.070]   File "/workspace/./test-infra/jenkins/../scenarios/execute.py", line 30, in check
W0226 18:53:31.070]     subprocess.check_call(cmd)
W0226 18:53:31.070]   File "/usr/lib/python2.7/subprocess.py", line 186, in check_call
W0226 18:53:31.094]     raise CalledProcessError(retcode, cmd)
W0226 18:53:31.095] subprocess.CalledProcessError: Command '('./hack/verify-bazel.sh',)' returned non-zero exit status 2
E0226 18:53:31.100] Command failed
I0226 18:53:31.100] process 404 exited with code 1 after 0.2m
E0226 18:53:31.100] FAIL: pull-test-infra-verify-bazel

@ixdy
Copy link
Member

ixdy commented Feb 26, 2018

same issue as in k/k kubernetes/kubernetes#60439.

we need to update gazelle and then vendor it so this doesn't happen again.

@ixdy
Copy link
Member

ixdy commented Feb 26, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit 21f98a2 into kubernetes:master Feb 26, 2018
@msau42 msau42 deleted the local-storage-e2e branch November 17, 2018 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants