Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the Resources for pull-verify-kueue-main #32339

Merged
merged 3 commits into from Apr 3, 2024

Conversation

Vandit1604
Copy link
Contributor

The verify job takes more than ~15 mins to complete, which adds more time to the release process. This is an attempt to check if increasing the resources for verify job reduces the time.

See for more info: kubernetes-sigs/kueue#1849

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 29, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @Vandit1604. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 29, 2024
@kannon92
Copy link
Contributor

kannon92 commented Apr 1, 2024

Can you look at the dashboards and see if we are hitting close to these limits?

@kannon92
Copy link
Contributor

kannon92 commented Apr 1, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 1, 2024
@kannon92
Copy link
Contributor

kannon92 commented Apr 1, 2024

/lgtm

I couldn't find the dashboard for kueue. Its only 4 cores so I think its worth a shot.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2024
@kannon92
Copy link
Contributor

kannon92 commented Apr 1, 2024

/assign @alculquicondor @mimowo

resources:
requests:
cpu: "2"
cpu: "4"
memory: "6Gi"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should probably allocate comparable memory?

1.5gi/core is pretty low, I'd aim for 2gi/core to start.


cc @mahamed @xmudrii interesting optimization problem: some jobs may be going slower due to artificially memory limiting themselves while still creating a cluster scaling bottleneck around allocated cores.

we should consider enforcing a core:mem limit to simplify this and make expectations more uniform between the EKS/GKE build clusters

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recurring topic #32315 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set the memory to 8Gi, as recommended

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@alculquicondor
Copy link
Member

Can you look at the dashboards and see if we are hitting close to these limits?

kubernetes-sigs/kueue#1849 (comment)

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2024
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 3, 2024
@Vandit1604
Copy link
Contributor Author

Vandit1604 commented Apr 3, 2024

@alculquicondor
Copy link
Member

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, Vandit1604

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2024
@kannon92
Copy link
Contributor

kannon92 commented Apr 3, 2024

@Vandit1604 thanks for sharing! I'm happy with this change given the discussion. Feel free to merge!

@Vandit1604
Copy link
Contributor Author

The failing tests looks unrelated to the changes in this PR or maybe I'm missing something here (?)

@alculquicondor
Copy link
Member

/retest

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit b8becde into kubernetes:master Apr 3, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@Vandit1604: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kueue-presubmits-main.yaml using file config/jobs/kubernetes-sigs/kueue/kueue-presubmits-main.yaml

In response to this:

The verify job takes more than ~15 mins to complete, which adds more time to the release process. This is an attempt to check if increasing the resources for verify job reduces the time.

See for more info: kubernetes-sigs/kueue#1849

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alculquicondor
Copy link
Member

Just FYI: This actually helped to reduce the runtime to almost half :)

@Vandit1604 Vandit1604 deleted the increase-number-of-cpus branch April 7, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants