New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase the Resources for pull-verify-kueue-main
#32339
Increase the Resources for pull-verify-kueue-main
#32339
Conversation
Hi @Vandit1604. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can you look at the dashboards and see if we are hitting close to these limits? |
/ok-to-test |
/lgtm I couldn't find the dashboard for kueue. Its only 4 cores so I think its worth a shot. |
/assign @alculquicondor @mimowo |
resources: | ||
requests: | ||
cpu: "2" | ||
cpu: "4" | ||
memory: "6Gi" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should probably allocate comparable memory?
1.5gi/core is pretty low, I'd aim for 2gi/core to start.
cc @mahamed @xmudrii interesting optimization problem: some jobs may be going slower due to artificially memory limiting themselves while still creating a cluster scaling bottleneck around allocated cores.
we should consider enforcing a core:mem limit to simplify this and make expectations more uniform between the EKS/GKE build clusters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recurring topic #32315 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please set the memory to 8Gi, as recommended
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
|
48185a1
to
f7bf281
Compare
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, Vandit1604 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Vandit1604 thanks for sharing! I'm happy with this change given the discussion. Feel free to merge! |
The failing tests looks unrelated to the changes in this PR or maybe I'm missing something here (?) |
/retest |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
@Vandit1604: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Just FYI: This actually helped to reduce the runtime to almost half :) |
The verify job takes more than ~15 mins to complete, which adds more time to the release process. This is an attempt to check if increasing the resources for verify job reduces the time.
See for more info: kubernetes-sigs/kueue#1849