Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.26 is out of support #32295

Merged
merged 1 commit into from Mar 22, 2024
Merged

1.26 is out of support #32295

merged 1 commit into from Mar 22, 2024

Conversation

kannon92
Copy link
Contributor

Also dropped a 1.25 that was hanging around..

cc @alculquicondor @mimowo @tenzen-y

I was doing this for jobset and wanted to open it up for Kueue.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 22, 2024
@kannon92
Copy link
Contributor Author

/assign @alculquicondor @tenzen-y

@k8s-ci-robot k8s-ci-robot requested a review from ahg-g March 22, 2024 16:27
@k8s-ci-robot k8s-ci-robot added the area/config Issues or PRs related to code in /config label Mar 22, 2024
@k8s-ci-robot k8s-ci-robot added area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 22, 2024
alculquicondor
alculquicondor reviewed Mar 22, 2024
View reviewed changes
config/jobs/kubernetes-sigs/kueue/kueue-presubmits-release-0-4.yaml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

alculquicondor
alculquicondor reviewed Mar 22, 2024
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8bc49a7 into kubernetes:master Mar 22, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@kannon92: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kueue-presubmits-main.yaml using file config/jobs/kubernetes-sigs/kueue/kueue-presubmits-main.yaml
  • key kueue-presubmits-release-0-4.yaml using file ``
  • key kueue-presubmits-release-0-5.yaml using file config/jobs/kubernetes-sigs/kueue/kueue-presubmits-release-0-5.yaml
  • key kueue-presubmits-release-0-6.yaml using file config/jobs/kubernetes-sigs/kueue/kueue-presubmits-release-0-6.yaml
  • key kueue-release-blocking.yaml using file config/jobs/kubernetes-sigs/kueue/kueue-release-blocking.yaml

In response to this:

Also dropped a 1.25 that was hanging around..

cc @alculquicondor @mimowo @tenzen-y

I was doing this for jobset and wanted to open it up for Kueue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@ahg-g ahg-g Awaiting requested review from ahg-g

Assignees

@alculquicondor alculquicondor

@tenzen-y tenzen-y

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kannon92 @k8s-ci-robot @alculquicondor @tenzen-y