Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure memory requests/limits are reasonable #32175

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ensure memory requests/limits are reasonable #32175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 8 additions & 8 deletions config/jobs/kubernetes-sigs/kueue/kueue-presubmits-release-0-4.yaml
View file
Open in desktop
Expand Up @@ -92,10 +92,10 @@ presubmits:
resources:
requests:
cpu: "10"
memory: "40Gi"
memory: "24Gi"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @tenzen-y @alculquicondor for kueue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the heads up. We reduced the limits in future versions. Changing it for the older version sgtm.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!

limits:
cpu: "10"
memory: "40Gi"
memory: "24Gi"
- name: pull-kueue-test-e2e-release-0-4-1-25
cluster: eks-prow-build-cluster
branches:
Expand Down Expand Up @@ -130,10 +130,10 @@ presubmits:
resources:
requests:
cpu: "10"
memory: "40Gi"
memory: "24Gi"
limits:
cpu: "10"
memory: "40Gi"
memory: "24Gi"
- name: pull-kueue-test-e2e-release-0-4-1-26
cluster: eks-prow-build-cluster
branches:
Expand Down Expand Up @@ -168,10 +168,10 @@ presubmits:
resources:
requests:
cpu: "10"
memory: "40Gi"
memory: "24Gi"
limits:
cpu: "10"
memory: "40Gi"
memory: "24Gi"
- name: pull-kueue-test-e2e-release-0-4-1-27
cluster: eks-prow-build-cluster
branches:
Expand Down Expand Up @@ -206,10 +206,10 @@ presubmits:
resources:
requests:
cpu: "10"
memory: "40Gi"
memory: "24Gi"
limits:
cpu: "10"
memory: "40Gi"
memory: "24Gi"
- name: pull-kueue-verify-release-0-4
cluster: eks-prow-build-cluster
branches:
Expand Down
20 changes: 10 additions & 10 deletions config/jobs/kubernetes/kops/kops-presubmits.yaml
View file
Open in desktop
Expand Up @@ -20,10 +20,10 @@ presubmits:
- "version-dist"
resources:
requests:
memory: "64Gi"
memory: "24Gi"
cpu: 8
limits:
memory: "64Gi"
memory: "24Gi"
cpu: 8
annotations:
testgrid-dashboards: sig-cluster-lifecycle-kops, presubmits-kops, kops-presubmits
Expand All @@ -48,10 +48,10 @@ presubmits:
- "test"
resources:
requests:
memory: "64Gi"
memory: "24Gi"
cpu: 8
limits:
memory: "64Gi"
memory: "24Gi"
cpu: 8
annotations:
testgrid-dashboards: sig-cluster-lifecycle-kops, presubmits-kops, kops-presubmits
Expand Down Expand Up @@ -343,10 +343,10 @@ presubmits:
- "govet"
resources:
requests:
memory: "64Gi"
memory: "24Gi"
cpu: 8
limits:
memory: "64Gi"
memory: "24Gi"
cpu: 8
annotations:
testgrid-dashboards: sig-cluster-lifecycle-kops, presubmits-kops, kops-presubmits
Expand All @@ -372,10 +372,10 @@ presubmits:
- "verify-golangci-lint"
resources:
requests:
memory: "64Gi"
memory: "24Gi"
cpu: 8
limits:
memory: "64Gi"
memory: "24Gi"
cpu: 8
annotations:
testgrid-dashboards: sig-cluster-lifecycle-kops, presubmits-kops, kops-presubmits
Expand All @@ -400,10 +400,10 @@ presubmits:
- "verify-hashes"
resources:
requests:
memory: "64Gi"
memory: "24Gi"
cpu: 8
limits:
memory: "64Gi"
memory: "24Gi"
cpu: 8
annotations:
testgrid-dashboards: sig-cluster-lifecycle-kops, presubmits-kops, kops-presubmits
Expand Down
8 changes: 4 additions & 4 deletions config/jobs/kubernetes/sig-k8s-infra/trusted/releng/releng-trusted.yaml
View file
Open in desktop
Expand Up @@ -61,10 +61,10 @@ postsubmits:
# request most of one node 🚀
requests:
cpu: 7
memory: "40Gi"
memory: 30Gi
limits:
cpu: 7
memory: "40Gi"
memory: 30Gi
annotations:
testgrid-dashboards: sig-release-releng-blocking, sig-k8s-infra-k8sio
testgrid-alert-email: k8s-infra-alerts@kubernetes.io, release-managers+alerts@kubernetes.io
Expand Down Expand Up @@ -259,10 +259,10 @@ periodics:
# request most of one node 🚀
requests:
cpu: 7
memory: "40Gi"
memory: 30Gi
limits:
cpu: 7
memory: "40Gi"
memory: 30Gi
annotations:
testgrid-dashboards: sig-release-releng-blocking, sig-k8s-infra-k8sio
testgrid-alert-email: k8s-infra-alerts@kubernetes.io, release-managers+alerts@kubernetes.io
Expand Down
4 changes: 2 additions & 2 deletions config/jobs/kubernetes/sig-k8s-infra/trusted/sig-k8s-infra-test-infra.yaml
View file
Open in desktop
Expand Up @@ -109,10 +109,10 @@ periodics:
resources:
requests:
cpu: 6
memory: 32Gi
memory: 24Gi
limits:
cpu: 6
memory: 32Gi
memory: 24Gi

- name: ci-test-infra-autobump-prowjobs
cron: "06 14-23 * * 1-5" # Run every hour at 7:06 - 16:06 PDT (in UTC) Mon-Fri
Expand Down
8 changes: 4 additions & 4 deletions config/jobs/kubernetes/sig-release/kubernetes-builds.yaml
View file
Open in desktop
Expand Up @@ -24,10 +24,10 @@ presubmits:
resources:
limits:
cpu: 7300m
memory: "41Gi"
memory: "16Gi"
requests:
cpu: 7300m
memory: "41Gi"
memory: "16Gi"
annotations:
testgrid-create-test-group: 'true'

Expand Down Expand Up @@ -62,10 +62,10 @@ periodics:
resources:
limits:
cpu: "7"
memory: "34Gi"
memory: "30Gi"
requests:
cpu: "7"
memory: "34Gi"
memory: "30Gi"
rerun_auth_config:
github_team_slugs:
- org: kubernetes
Expand Down
32 changes: 16 additions & 16 deletions config/jobs/kubernetes/sig-release/release-branch-jobs/1.26.yaml
View file
Open in desktop
Expand Up @@ -165,10 +165,10 @@ periodics:
resources:
limits:
cpu: "7"
memory: 34Gi
memory: 30Gi
requests:
cpu: "7"
memory: 34Gi
memory: 30Gi
securityContext:
privileged: true
- annotations:
Expand Down Expand Up @@ -391,11 +391,11 @@ periodics:
name: ""
resources:
limits:
cpu: "4"
memory: 36Gi
cpu: "7"
memory: 30Gi
requests:
cpu: "4"
memory: 36Gi
cpu: "7"
memory: 30Gi
- annotations:
fork-per-release-periodic-interval: 24h
testgrid-alert-email: kubernetes-sig-testing-alerts@googlegroups.com, k8s-infra-oncall@google.com, release-managers+alerts@kubernetes.io
Expand Down Expand Up @@ -1616,11 +1616,11 @@ presubmits:
name: ""
resources:
limits:
cpu: "4"
memory: 36Gi
cpu: "7"
memory: 30Gi
requests:
cpu: "4"
memory: 36Gi
cpu: "7"
memory: 30Gi
- always_run: true
annotations:
description: run with GO_VERSION set to the original go version used for this branch
Expand All @@ -1645,11 +1645,11 @@ presubmits:
name: ""
resources:
limits:
cpu: "4"
memory: 36Gi
cpu: "7"
memory: 30Gi
requests:
cpu: "4"
memory: 36Gi
cpu: "7"
memory: 30Gi
- always_run: true
branches:
- release-1.26
Expand All @@ -1672,10 +1672,10 @@ presubmits:
resources:
limits:
cpu: "5"
memory: 32Gi
memory: 16Gi
requests:
cpu: "5"
memory: 32Gi
memory: 16Gi
- always_run: false
branches:
- release-1.26
Expand Down
32 changes: 16 additions & 16 deletions config/jobs/kubernetes/sig-release/release-branch-jobs/1.27.yaml
View file
Open in desktop
Expand Up @@ -170,10 +170,10 @@ periodics:
resources:
limits:
cpu: "7"
memory: 34Gi
memory: 30Gi
requests:
cpu: "7"
memory: 34Gi
memory: 30Gi
securityContext:
privileged: true
- annotations:
Expand Down Expand Up @@ -397,11 +397,11 @@ periodics:
name: ""
resources:
limits:
cpu: "4"
memory: 36Gi
cpu: "7"
memory: 30Gi
requests:
cpu: "4"
memory: 36Gi
cpu: "7"
memory: 30Gi
securityContext:
allowPrivilegeEscalation: false
securityContext:
Expand Down Expand Up @@ -1569,11 +1569,11 @@ presubmits:
name: ""
resources:
limits:
cpu: "4"
memory: 36Gi
cpu: "7"
memory: 30Gi
requests:
cpu: "4"
memory: 36Gi
cpu: "7"
memory: 30Gi
securityContext:
allowPrivilegeEscalation: false
securityContext:
Expand Down Expand Up @@ -1601,11 +1601,11 @@ presubmits:
name: ""
resources:
limits:
cpu: "4"
memory: 36Gi
cpu: "7"
memory: 30Gi
requests:
cpu: "4"
memory: 36Gi
cpu: "7"
memory: 30Gi
securityContext:
allowPrivilegeEscalation: false
securityContext:
Expand Down Expand Up @@ -1633,10 +1633,10 @@ presubmits:
resources:
limits:
cpu: "5"
memory: 32Gi
memory: 16Gi
requests:
cpu: "5"
memory: 32Gi
memory: 16Gi
- always_run: false
branches:
- release-1.27
Expand Down