Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to go1.22 #3514

Merged
merged 1 commit into from Mar 18, 2024
Merged

upgrade to go1.22 #3514

merged 1 commit into from Mar 18, 2024

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Mar 16, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • upgrade to go1.22

/hold for test-infra job update

/assign @saschagrunert @xmudrii @puerco
cc @kubernetes/release-engineering

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

upgrade to go1.22

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 16, 2024
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 16, 2024
@k8s-ci-robot k8s-ci-robot added the area/release-eng Issues or PRs related to the Release Engineering subproject label Mar 16, 2024
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 16, 2024
@cpanato
Copy link
Member Author

cpanato commented Mar 16, 2024

test-infra job update kubernetes/test-infra#32273

@cpanato
Copy link
Member Author

cpanato commented Mar 17, 2024

/retest

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 17, 2024
@cpanato
Copy link
Member Author

cpanato commented Mar 17, 2024

/test pull-release-image-go-runner

@saschagrunert
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member

@cpanato CI is not happy:

./hack/verify-dependencies.sh
level=error msg="./hack/../dependencies.yaml indicates that golang: go.mod should be at version 1.22, but the following files didn't match: images/build/go-runner/go.mod"
level=fatal msg="error during command execution: &fmt.wrapError{msg:\"checking local dependencies: Dependencies are not in sync\", err:(*errors.errorString)(0xc000538d40)}"

Signed-off-by: cpanato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2024
Copy link
Contributor

@Verolop Verolop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2024
@cpanato
Copy link
Member Author

cpanato commented Mar 18, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2024
@k8s-ci-robot k8s-ci-robot merged commit af5c371 into kubernetes:master Mar 18, 2024
10 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Mar 18, 2024
@cpanato cpanato deleted the upgrade-go-122 branch March 18, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants