New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
images: Use crane for pushing release images instead of docker #3494
base: master
Are you sure you want to change the base?
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@claudiubelu: Adding label: Reasons for blocking this PR:[Changes to push-build.sh will immediately affect the Kubernetes CI. This PR must be explicitly approved by SIG Release repo admins.] Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/test pull-release-cluster-up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the pr
a few comments
1e14690
to
5623879
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: claudiubelu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5623879
to
01e3f72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits to consider. Thank you for this PR!
push-build.sh
Outdated
echo "Installing crane..." | ||
CRANE_VERSION="v0.19.1" | ||
BASE_URL="https://github.com/google/go-containerregistry/releases/download" | ||
TAR_NAME="go-containerregistry_Linux_x86_64.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure that this script is only used on amd64 systems? cc @kubernetes/release-engineering
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, changed to TAR_NAME="go-containerregistry_Linux_$(uname -p).tar.gz"
, which should include the processor type.
01e3f72
to
19e3234
Compare
Currently, we're loading the images into docker, retagging them, and then push them onto the registry. This workflow is incompatible with Windows images, as docker load does not work for them, resulting in the following error: cannot load windows image on linux However, crane does not load the image, it just pushes it directly with the given tag. This will allow us to push any Windows image we might have (e.g.: Windows kube-proxy image).
19e3234
to
d04801a
Compare
/test pull-release-cluster-up |
Any idea why the |
/retest |
@claudiubelu: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This job seems to have failed for a long time, let me create an issue for it. Edit: #3588 |
What type of PR is this?
What this PR does / why we need it:
Currently, we're loading the images into docker, retagging them, and then push them onto the registry.
This workflow is incompatible with Windows images, as docker load does not work for them, resulting in the following error:
However, crane does not load the image, it just pushes it directly with the given tag. This will allow us to push any Windows image we might have (e.g.: Windows kube-proxy image).
Which issue(s) this PR fixes:
Related: kubernetes/kubernetes@7f04e49
Special notes for your reviewer:
Does this PR introduce a user-facing change?