Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site: Update hugo from v0.124.1 to v0.125.6 #18687

Merged
merged 1 commit into from May 7, 2024

Conversation

minikube-bot
Copy link
Collaborator

The hugo project released a new version

This PR was auto-generated by make update-hugo-version using update-hugo-version.yml CI Workflow.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 18, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @minikube-bot. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 18, 2024
@spowelljr
Copy link
Member

The site build is failing with:

ERROR render of "section" failed: "/Users/powellsteven/repo/minikube/site/themes/docsy/layouts/docs/baseof.html:4:7": execute of template failed: template: docs/list.html:4:7: executing "docs/list.html" at <partial "head.html" .>: error calling partial: execute of template failed: html/template:partials/head.html:53:16: no such template "_internal/google_analytics_async.html"
ERROR render of "page" failed: "/Users/powellsteven/repo/minikube/site/themes/docsy/layouts/docs/baseof.html:4:7": execute of template failed: template: docs/single.html:4:7: executing "docs/single.html" at <partial "head.html" .>: error calling partial: execute of template failed: html/template:partials/head.html:53:16: no such template "_internal/google_analytics_async.html"
Built in 1237 ms
Error: error building site: render: failed to render pages: render of "home" failed: "/Users/powellsteven/repo/minikube/site/themes/docsy/layouts/_default/baseof.html:4:7": execute of template failed: template: home.html:4:7: executing "home.html" at <partial "head.html" .>: error calling partial: execute of template failed: html/template:partials/head.html:53:16: no such template "_internal/google_analytics_async.html"

Looks like it's out of our control, it's related to the broader Kubernetes injecting Google Analytics

@spowelljr spowelljr added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2024
@medyagh medyagh changed the title Site: Update hugo from v0.124.1 to v0.125.1 HOLD: Site: Update hugo from v0.124.1 to v0.125.1 Apr 18, 2024
@spowelljr
Copy link
Member

I was wrong about the injection thing, it's something we have control over, I found the source of the error here in site/themes/docsy/layouts/partials/head.html:

{{ if hugo.IsProduction -}}
  {{ $enableGtagForUniversalAnalytics := not .Site.Params.disableGtagForUniversalAnalytics -}}
  {{ if (or $enableGtagForUniversalAnalytics (hasPrefix .Site.GoogleAnalytics "G-")) -}}
    {{ template "_internal/google_analytics_gtag.html" . -}}
  {{ else -}}
    {{ template "_internal/google_analytics_async.html" . -}}
  {{ end -}}
{{ end -}}

We're hitting the else statement for some reason when I'm assuming we were hitting if before the version bump.

@spowelljr
Copy link
Member

Related to gohugoio/hugo#12299

@spowelljr
Copy link
Member

Also related to google/docsy#1879

@spowelljr
Copy link
Member

Ignore some of the above info, I figured out the bug myself but then found that there was an existing issue (google/docsy#1930) and PR (google/docsy#1931). Need that merged and then a new Docsy release and then we can update Hugo.

@minikube-bot minikube-bot changed the title HOLD: Site: Update hugo from v0.124.1 to v0.125.1 Site: Update hugo from v0.124.1 to v0.125.2 Apr 22, 2024
@minikube-bot minikube-bot changed the title Site: Update hugo from v0.124.1 to v0.125.2 Site: Update hugo from v0.124.1 to v0.125.4 Apr 25, 2024
@minikube-bot minikube-bot force-pushed the auto_bump_hugo_version branch 2 times, most recently from 893a65f to 1581dcb Compare April 29, 2024 10:03
@minikube-bot minikube-bot changed the title Site: Update hugo from v0.124.1 to v0.125.4 Site: Update hugo from v0.124.1 to v0.125.6 May 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: minikube-bot, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2024
@spowelljr spowelljr merged commit db7f5fe into kubernetes:master May 7, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants