Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump macos version to 13 #18609

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ComradeProgrammer
Copy link
Contributor

@ComradeProgrammer ComradeProgrammer commented Apr 9, 2024

ci: bump macos version to 13

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 9, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @ComradeProgrammer. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ComradeProgrammer
Once this PR has been reviewed and has the lgtm label, please assign spowelljr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 9, 2024
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@ComradeProgrammer
Copy link
Contributor Author

ComradeProgrammer commented Apr 9, 2024

@spowelljr @medyagh could you please type an ok-to-test?
Now I changed the value of runs-on to [macos-13,x64] according to https://docs.github.com/en/actions/using-jobs/choosing-the-runner-for-a-job

I think it may work

@spowelljr
Copy link
Member

The additional tags are for self-hosted runners where you specify the tags on the runner itself, I don't think this is going to work.

@ComradeProgrammer
Copy link
Contributor Author

The additional tags are for self-hosted runners where you specify the tags on the runner itself, I don't think this is going to work.

I see. I shall try something else later

@ComradeProgrammer
Copy link
Contributor Author

ComradeProgrammer commented Apr 15, 2024

I think this time it might work.
Basically, what I did is that adding a new workflow into the github action. This workflow use PR workflow as its dependency, so that it will be triggered once this workflow is finished.

This workflow will try to use gh commandline to check the log of its depedent PR workflow to see if there are warnings about incorrect architecture(gh run view ${{ github.event.workflow_run.id }} --log | grep ':type=>:arm') .

If such error is found in the log, then it will try to fetch the jobid of PR / functional_virtualbox_macos ( gh run view ${{ github.event.workflow_run.id }} --json jobs | jq '.jobs[] | select ( .name == "functional_virtualbox_macos") | .databaseId')and rerun it(gh run rerun --job $JOBID)

I created a test repo and used a simplified version of it, and I think it works. However, it seems that this change cannot take effect before it is merged.

@@ -0,0 +1,35 @@
# This is a basic workflow to help you get started with Actions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add better comments and explain what is this and why we need it

@medyagh
Copy link
Member

medyagh commented Apr 15, 2024

mmandline to check the log of its depedent PR workflow to see if there are warnings about incorrect architecture(gh run view ${{ github.event.workflow_run.id }} --log | grep ':type=>:arm') .

If such error is found in the log, then it will try to fetch the jobid of PR / functional_vir

cool, lets see if you can make the Test Pass too ?

@ComradeProgrammer ComradeProgrammer changed the title WIP ci: bump macos version to 13 ci: bump macos version to 13 Apr 20, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 20, 2024
.github/workflows/pr.yml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants