Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PetSets no longer supported in favor of StatefulSets #41926

Closed
Dbz opened this issue Feb 22, 2017 · 2 comments
Closed

PetSets no longer supported in favor of StatefulSets #41926

Dbz opened this issue Feb 22, 2017 · 2 comments

Comments

@Dbz
Copy link

Dbz commented Feb 22, 2017

I think the humanitarian change of PetSet to StatefulSet is a good one, and StatefulSet as a name makes more sense than PetSet; however, I feel the best software development practice is to not to make an API breaking change (I understand with v1alpha1 this is debatable) and deprecate the functionality while giving people time to upgrade their configurations. We should also display a deprecated message when applying/creating a PetSet to use a StatefulSet. While this isn't a huge issue for this tiny change, it represents a standard for moving forward. As a codebase/community we should be very cautious when introducing breaking changes and give everyone plenty of time to prepare for them. I sincerely apologize if this was discussed and dismissed earlier, and I am not intending to flame nor cause any sort of controversy nor waste anyone's time (I apologize if this is the case.).

Keyword searches: PetSet StatefulSet
Relevant Discussion

FEATURE REQUEST:

Deprecate PetSets (but still allow them to be used) and post a message on apply/create that PetSets are deprecated and will be removed in the next version.

Kubernetes version (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"5", GitVersion:"v1.5.3", GitCommit:"029c3a408176b55c30846f0faedf56aae5992e9b", GitTreeState:"clean", BuildDate:"2017-02-17T20:48:54Z", GoVersion:"go1.8", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"4", GitVersion:"v1.4.5+coreos.0", GitCommit:"f70c2e5b2944cb5d622621a706bdec3d8a5a9c5e", GitTreeState:"clean", BuildDate:"2016-10-31T19:16:47Z", GoVersion:"go1.6.3", Compiler:"gc", Platform:"linux/amd64"}

What happened:

When we updated our kubectl and applied a change to a PetSet, it rejected the PetSet and gave an error. We did not update our server.

What you expected to happen:

We expected the PetSet update to be applied to our cluster

How to reproduce it (as minimally and precisely as possible):

Apply a PetSet using the latest version of kubectl

@jaygorrell
Copy link

I believe unsupported name changes are considered fair game for things in the apps/v1alpha1 API.

@Dbz
Copy link
Author

Dbz commented Feb 23, 2017

I am closing this issue due to the api documentation for Alpha level clearly stating:

The API may change in incompatible ways in a later software release without notice.

@Dbz Dbz closed this as completed Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants