windows: Fixes following container log rotation #124444
Open
+84
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: claudiubelu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-ci-kubernetes-unit-windows |
claudiubelu
force-pushed
the
windows/fix-container-log-rotation
branch
4 times, most recently
from
085c9ed
to
1571613
Compare
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
SergeyKanzhelev
moved this from Triage
to PRs - Needs Reviewer
in SIG Node CI/Test Board
If we're following a file, that file will remain open, and we continue to read data from it when new data becomes available. On Windows, this can be an issue if the container logs needs to be rotated. Log rotation is done by renaming the file, but this action may fail if the file is already opened. Setting the FILE_SHARE_DELETE flag when opening the file will prevent this issue, as documented: "Delete access allows both delete and rename operations" [1]. In golang, there's no way to set this flag [2], the sharemode is always set to: sharemode := uint32(FILE_SHARE_READ | FILE_SHARE_WRITE) Thus, we need to open the file ourselves with the right flags. [1] https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilea?redirectedfrom=MSDN [2] https://cs.opensource.google/go/go/+/refs/tags/go1.22.2:src/syscall/syscall_windows.go;l=366
claudiubelu
force-pushed
the
windows/fix-container-log-rotation
branch
from
1571613
to
96f62df
Compare
|
All Windows unit tests passed btw. So, this fixed the issue. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 6015586a00ce03d790ad84986d2408228bcf304e
|
|
/assign @mrunalp @derekwaynecarr @dchen1107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind failing-test
/sig windows
/sig testing
What this PR does / why we need it:
If we're following a file, that file will remain open, and we continue to read data from it when new data becomes available.
On Windows, this can be an issue if the container logs needs to be rotated. Log rotation is done by renaming the file, but this action may fail if the file is already opened.
Setting the
FILE_SHARE_DELETEflag when opening the file will prevent this issue, as documented:"Delete access allows both delete and rename operations"[1].In golang, there's no way to set this flag [2], the
sharemodeis always set to:sharemode := uint32(FILE_SHARE_READ | FILE_SHARE_WRITE)Thus, we need to open the file ourselves with the right flags.
[1] https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilea?redirectedfrom=MSDN
[2] https://cs.opensource.google/go/go/+/refs/tags/go1.22.2:src/syscall/syscall_windows.go;l=366
Which issue(s) this PR fixes:
Fixes #124443
Related: #51540
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: