New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LinuxOnly] is egregiously misused at least in sig-network tests #124426
Comments
/triage accepted |
Hello, Indeed, there are quite a few tests which are marked as
Also worth mentioning that there may be more tests which are being skipped on Windows through something like Also note that non-Conformance tests are not typically tested as the Conformance ones, so I can't say much about them passing or not. There were some efforts in the past for promoting more networking tests to Conformance [7], but that effort seems discontinued at this point. Now, regarding the tests you've mentioned:
[1] #101063 [7] #73425 |
Sure, but they all involve documented features that users might want to use. And as you said, we do eventually want to move more tests toward Conformance, so Windows really ought to be aiming to pass everything that isn't truly linux-specific.
No... I was only looking at
No, sorry, I should have listed these out. The
Perhaps the others are skipped rather than labeled.
Yes
SCTP isn't even implemented by most Linux network plugins and it seems like sig-windows already has too much to do anyway, so it seems reasonable to just say that it's not supported on Windows. If someone wants to get it to be officially-supported then they can do the work... |
/assign @sebsoto |
In
test/e2e/network
, there are currently 45 tests marked[LinuxOnly]
, of which it seems that 37 are incorrect or at least dubious:SessionAffinity
, which was implemented inpkg/proxy/winkernel
4 years agohostNetwork
pods, which now exist in alpha on Windows, so we ought to at least optionally be running them thereThe seemingly-correct ones:
kubernetes.default.svc
) which apparently are not supported by the Windows resolvercc @claudiubelu @knabben @MikeZappa87
/sig windows
/sig network
The text was updated successfully, but these errors were encountered: