-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add marker comment support for annotating cluster scopedness #470
base: master
Are you sure you want to change the base?
Conversation
/lgtm |
/hold for time for jpbetz comment and final verification it works as expected upstream |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexzielenski, Jefftree, jpbetz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a5e08fc
to
440e1ca
Compare
New changes are detected. LGTM label has been removed. |
440e1ca
to
120d97c
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Adds new marker comments to specify whether the kind is namespace or cluster scoped using e.g.:
+k8s:validation:scope>Namespaced