Add cpu management policy config

[lynchc]

This adds the --cpu-manager-policy to the kubelet config

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: helpdesk@rt.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Hi @lynchc. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lynchc]

CLA Signed

[chrisz100]

/check-cla

Please ensure you signed the cla with the email address used for your commits.

[lynchc]

confirmed. same email as gh primary. verified login to linux foundation. Also just added gh as a social network link on that account.

[chrisz100]

The engine matches against the email in the actual commit - so what you configured your git client to.

/check-cla

[lynchc]

same email in my .gitconfig. I can paste screenshots of everything matching if you want

[blakebarnett]

Is it because the domain doesn't match the company CLA domain?

[chrisz100]

As it's public domain - the CLA needs to be signed with the gmail address from imissmymind259 - I don't know if you already did that or what email you used. Just that the verifier doesn't find you for that email and before that's done we can't proceed in the process here I'm afraid.

[lynchc]

[chrisz100]

@justinsb any other idea?

[lynchc]

bumping on this. Anything I can do to get this moving / further verify the CLA?

[mikesplain]

@lynchc can you submit a ticket with the CNCF? helpdesk@rt.linuxfoundation.org from the message above.

[justinsb]

/ok-to-test

Checked the individual commits and they all have the same email, which is often the case. Hoping it is related to ok-to-test.

Also reopened the tracking issue kubernetes/kubernetes#27796

[justinsb]

Really sorry about the CLA bot here - we can try asking the helpdesk, but it sounds like we are replacing the CLA bot entirely with something open source, so hopefully then we'll be able to see and fix these problems.

I'm afraid I'm going to have to move this to 1.12, but if the CLA bot wakes up then we can likely put it into 1.11, as mapping a field is very low risk (and given the circumstances)

[hipyhop]

EDIT: Nevermind. I've just realised this change needs to be built into nodeup too.

I've just tested this and the --cpu-manager-policy=static flag is not being set in the kubelet args.
I don't see it included in /etc/sysconfig/kubelet

Is there anything else that needs adding other than the below snippet?

spec:
  kubelet:
    cpuManagerPolicy: static

[lynchc]

I signed it

[chrisz100]

Wow, cla stuff is resolved! Can you please rebase this? Thanks!

[lynchc]

ya finally made it back to this. Filed a ticket and they got me squared away. rebase coming

[chrisz100]

It’s just something additional, would not regard this as a breaking change.

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisz100, lynchc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [chrisz100]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lynchc]

oh it looks like I left the old option and added the new name instead of replacing. let me remove that

[chrisz100]

/hold

[chrisz100]

/hold cancel
/lgtm

[lynchc]

apologies for the mess. should be squared away now