Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Owners: Promote Gacko to ingress-nginx-maintainers & ingress-nginx-reviewers. #11165

Merged
merged 6 commits into from Apr 4, 2024
Merged

Owners: Promote Gacko to ingress-nginx-maintainers & ingress-nginx-reviewers. #11165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0cb444b
Owners: Sort `ingress-nginx-maintainers` & `ingress-nginx-reviewers`.
Gacko Mar 26, 2024
be95996
Owners: Update URL in aliases.
Gacko Mar 26, 2024
9648912
Images: Remove owners as it's identical to global owners.
Gacko Mar 26, 2024
18da675
Images: Remove global owners from `kube-webhook-certgen` owners.
Gacko Mar 26, 2024
3b43dbf
Owners: Remove members from aliases covered by other aliases.
Gacko Mar 26, 2024
db604e9
Owners: Promote myself to `ingress-nginx-maintainers` & `ingress-ngin…
Gacko Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions OWNERS
View file
Open in desktop
@@ -1,4 +1,4 @@
# See the OWNERS docs: https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md
# See the OWNERS docs: https://www.kubernetes.dev/docs/guide/owners

approvers:
- ingress-nginx-maintainers
Expand All @@ -7,6 +7,6 @@ reviewers:
- ingress-nginx-reviewers

emeritus_approvers:
- aledbf # 2020-04-02
- aledbf # 2020-04-02
- bowei # 2022-10-12
- ElvinEfendi # 2023-04-23
19 changes: 7 additions & 12 deletions OWNERS_ALIASES
View file
Open in desktop
@@ -1,4 +1,4 @@
# See the OWNERS docs: https://git.k8s.io/community/docs/devel/owners.md
# See the OWNERS docs: https://www.kubernetes.dev/docs/guide/owners

aliases:
sig-network-leads:
Expand All @@ -11,34 +11,29 @@ aliases:
- strongjz

ingress-nginx-maintainers:
- rikatz
- strongjz
Gacko marked this conversation as resolved.
Show resolved Hide resolved
- cpanato
- Gacko
- puerco
- rikatz
- strongjz
- tao12345666333

ingress-nginx-reviewers:
- cpanato
- Gacko
- puerco
- rikatz
Gacko marked this conversation as resolved.
Show resolved Hide resolved
- strongjz
- puerco
- cpanato
- tao12345666333

ingress-nginx-helm-maintainers:
- cpanato
Gacko marked this conversation as resolved.
Show resolved Hide resolved
- Gacko
- strongjz
- ubergesundheit

ingress-nginx-helm-reviewers:
- cpanato
Gacko marked this conversation as resolved.
Show resolved Hide resolved
- Gacko
- strongjz
- ubergesundheit

ingress-nginx-docs-maintainers:
- longwuyuan
- tao12345666333

ingress-nginx-kube-webhook-certgen-reviewers:
- invidian
2 changes: 1 addition & 1 deletion charts/ingress-nginx/OWNERS
View file
Open in desktop
@@ -1,4 +1,4 @@
# See the OWNERS docs: https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md
# See the OWNERS docs: https://www.kubernetes.dev/docs/guide/owners

approvers:
- ingress-nginx-helm-maintainers
Expand Down
4 changes: 2 additions & 2 deletions docs/OWNERS
View file
Open in desktop
@@ -1,7 +1,7 @@
# See the OWNERS docs: https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md
# See the OWNERS docs: https://www.kubernetes.dev/docs/guide/owners

approvers:
- ingress-nginx-docs-maintainers

labels:
- area/docs
- area/docs
9 changes: 0 additions & 9 deletions images/OWNERS
View file
Open in desktop

This file was deleted.

8 changes: 1 addition & 7 deletions images/kube-webhook-certgen/OWNERS
View file
Open in desktop
@@ -1,10 +1,4 @@
# See the OWNERS docs: https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md

approvers:
Gacko marked this conversation as resolved.
Show resolved Hide resolved
- ingress-nginx-admins
- ingress-nginx-maintainers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should keep at least the maintainers or drop the entire file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then we would also revoke reviewer privileges for @invidian. Is this intended?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the ingress-nginx-maintainers still works here then it is fine

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should. I searched some older, already approved and merged PRs to check if the inheritance from the root OWNERS works, see above. According to my investigations and the docs it should work!

# See the OWNERS docs: https://www.kubernetes.dev/docs/guide/owners

reviewers:
- ingress-nginx-admins
- ingress-nginx-maintainers
- ingress-nginx-kube-webhook-certgen-reviewers
4 changes: 2 additions & 2 deletions rootfs/etc/nginx/lua/OWNERS
View file
Open in desktop
@@ -1,4 +1,4 @@
# See the OWNERS docs: https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md
# See the OWNERS docs: https://www.kubernetes.dev/docs/guide/owners

labels:
- area/lua
- area/lua