Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Lua resty.balancer module to 0.05 #11123

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zengyuxing007
Copy link
Contributor

@zengyuxing007 zengyuxing007 commented Mar 14, 2024

Lua resty.balancer module version 0.04 have a known risk that insufficient memory can lead to a crash.

We have encountered this issue in our production environment. (#11125)

ref PR:openresty/lua-resty-balancer@a7a8b62

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 14, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 14, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @zengyuxing007. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 14, 2024
Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for kubernetes-ingress-nginx ready!

Name Link
🔨 Latest commit bbfd46f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/65f3acf5e9aad40008fb9c5f
😎 Deploy Preview https://deploy-preview-11123--kubernetes-ingress-nginx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 14, 2024
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions

images/nginx/rootfs/build.sh Outdated Show resolved Hide resolved
@strongjz
Copy link
Member

/assign @strongjz
/triage accepted
/kind bug
/ok-to-test

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/bug Categorizes issue or PR as related to a bug. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 14, 2024
@cpanato
Copy link
Member

cpanato commented Mar 15, 2024

/lgtm
/hold for @strongjz

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, zengyuxing007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2024
@rikatz
Copy link
Contributor

rikatz commented Mar 17, 2024

question: is this a problem on ingress v1.10? We are using nginx v1.25 and I didn't saw an update there

@zengyuxing007
Copy link
Contributor Author

question: is this a problem on ingress v1.10? We are using nginx v1.25 and I didn't saw an update there

This is an issue with the resty.balancer module under openresty, and it is not related to the nginx version. This means it should also exist in v1.10 (nginx v1.25).

@rikatz
Copy link
Contributor

rikatz commented Mar 18, 2024

https://github.com/kubernetes/ingress-nginx/blob/main/images/nginx-1.25/rootfs/build.sh#L66

/approve cancel

Please check other images build that may be using, in this case, on NGINX v1.25 base image that we use for ingress-nginx it is already using the latest commit

@zengyuxing007
Copy link
Contributor Author

https://github.com/kubernetes/ingress-nginx/blob/main/images/nginx-1.25/rootfs/build.sh#L66

/approve cancel

Please check other images build that may be using, in this case, on NGINX v1.25 base image that we use for ingress-nginx it is already using the latest commit

image

This commit is the same as the one in v0.05.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants