Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chart: Improve IngressClass documentation. #11104

Merged
merged 1 commit into from Mar 12, 2024
Merged

Chart: Improve IngressClass documentation. #11104

merged 1 commit into from Mar 12, 2024

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Mar 11, 2024 •
edited

What this PR does / why we need it:

This PR improves the existing documentation of the IngressClass resource.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

Towards #10614.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 11, 2024
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. area/helm Issues or PRs related to helm charts needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 11, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 11, 2024 •
edited

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit 8944bcf
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/65ef78f31c35d20008be883a

@Gacko
Copy link
Member Author

Gacko commented Mar 11, 2024

/cherry-pick release-1.10

@k8s-infra-cherrypick-robot
Copy link

@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Gacko
Copy link
Member Author

Gacko commented Mar 11, 2024

/assign @ubergesundheit
cc @strongjz

@Gacko
Copy link
Member Author

Gacko commented Mar 11, 2024

/triage accepted
/kind documentation
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/documentation Categorizes issue or PR as related to documentation. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Mar 11, 2024
@Gacko
Copy link
Member Author

Gacko commented Mar 11, 2024

Hopefully this is not working:

/approve

@Gacko
Copy link
Member Author

Gacko commented Mar 11, 2024

/lgtm

@k8s-ci-robot
Copy link
Contributor

@Gacko: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Gacko Gacko force-pushed the uhpxn branch 4 times, most recently from ef3140b to f064333 Compare March 11, 2024 19:49
cpanato
cpanato approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to me

/approve
/hold for eyes if need

charts/ingress-nginx/README.md Show resolved Hide resolved
charts/ingress-nginx/values.yaml Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2024
@Gacko
Copy link
Member Author

Gacko commented Mar 11, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2024
@Gacko
Copy link
Member Author

Gacko commented Mar 12, 2024

/assign

This was referenced Mar 12, 2024
Merged
Merged
@Gacko Gacko requested a review from cpanato March 12, 2024 11:53
@Gacko
Copy link
Member Author

Gacko commented Mar 12, 2024

@cpanato: Seems your approval was not enough for Tide, probably because of the hold.

@strongjz
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, Gacko, strongjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2894b8a into kubernetes:main Mar 12, 2024
17 checks passed
@Gacko Gacko deleted the uhpxn branch March 12, 2024 13:40
@k8s-infra-cherrypick-robot
Copy link

@Gacko: new pull request created: #11111

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Mar 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longwuyuan longwuyuan longwuyuan left review comments

@strongjz strongjz Awaiting requested review from strongjz

@ubergesundheit ubergesundheit Awaiting requested review from ubergesundheit

@cpanato cpanato Awaiting requested review from cpanato

Assignees

@Gacko Gacko

@ubergesundheit ubergesundheit

@strongjz strongjz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/helm Issues or PRs related to helm charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Gacko @k8s-infra-cherrypick-robot @k8s-ci-robot @strongjz @cpanato @longwuyuan @ubergesundheit