Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golangci-lint update, ci cleanup, group dependabot updates #11071

Merged
merged 6 commits into from Mar 7, 2024
Merged

golangci-lint update, ci cleanup, group dependabot updates #11071

merged 6 commits into from Mar 7, 2024

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Mar 7, 2024

What this PR does / why we need it:

  • golangci-lint update, ci cleanup, group dependabot updates

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

none

/assign @rikatz @strongjz

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

@cpanato
bump golangci-lint to v1.56.x
fa5e154 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
cleanup empty lines
ee54e79 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
group dependabot updates
5c28415 
Signed-off-by: cpanato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 7, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 7, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 7, 2024 •
edited

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit 09f7b11
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/65e92ca3f8882b0008763469

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2024
@cpanato
run on job changes as well
fff011c 
Signed-off-by: cpanato <ctadeu@gmail.com>
@strongjz
Copy link
Member

strongjz commented Mar 7, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2024
@cpanato
Copy link
Member Author

cpanato commented Mar 7, 2024

/hold doing lint fixes

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2024
@cpanato
remove deprecated checks
7ba0db2 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
fix lints and format
09f7b11 
Signed-off-by: cpanato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 7, 2024
@cpanato
Copy link
Member Author

cpanato commented Mar 7, 2024

can you PTAL @strongjz ? thanks

@cpanato
Copy link
Member Author

cpanato commented Mar 7, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2024
@rikatz
Copy link
Contributor

rikatz commented Mar 7, 2024

/lgtm
/approve
thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, rikatz, strongjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,rikatz,strongjz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 12fbe9b into kubernetes:main Mar 7, 2024
38 checks passed
@cpanato cpanato deleted the update-golangci-lint branch March 7, 2024 11:20
@Gacko
Copy link
Member

Gacko commented Mar 11, 2024

/cherry-pick release-1.10

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Mar 11, 2024
Closed
@k8s-infra-cherrypick-robot
Copy link

@Gacko: new pull request created: #11102

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Gacko pushed a commit to Gacko/ingress-nginx that referenced this pull request Mar 11, 2024
@cpanato @Gacko
golangci-lint update, ci cleanup, group dependabot updates (kubernete…
1056625 
…s#11071)

* bump golangci-lint to v1.56.x

Signed-off-by: cpanato <ctadeu@gmail.com>

* cleanup empty lines

Signed-off-by: cpanato <ctadeu@gmail.com>

* group dependabot updates

Signed-off-by: cpanato <ctadeu@gmail.com>

* run on job changes as well

Signed-off-by: cpanato <ctadeu@gmail.com>

* remove deprecated checks

Signed-off-by: cpanato <ctadeu@gmail.com>

* fix lints and format

Signed-off-by: cpanato <ctadeu@gmail.com>

---------

Signed-off-by: cpanato <ctadeu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strongjz strongjz Awaiting requested review from strongjz

@tao12345666333 tao12345666333 Awaiting requested review from tao12345666333

Assignees

@strongjz strongjz

@rikatz rikatz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cpanato @k8s-ci-robot @strongjz @rikatz @Gacko @k8s-infra-cherrypick-robot