Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chart: Deploy PodDisruptionBudget with KEDA. #11032

Merged
merged 6 commits into from Mar 11, 2024
Merged

Chart: Deploy PodDisruptionBudget with KEDA. #11032

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
29c4237
feat: deploy PDB if Keda is enabled and the minimum amount of replica…
StuxxNet Feb 27, 2024
5f194a7
feat: add the corresponding unit-test to check PDB deployment with Keda
StuxxNet Feb 27, 2024
97a4f84
chore: rename the test of PDB to follow suggested pattern
StuxxNet Feb 27, 2024
b869ebc
chore: update the test-case suite name to the new format
StuxxNet Feb 27, 2024
6480e14
Update charts/ingress-nginx/templates/controller-poddisruptionbudget.…
StuxxNet Mar 11, 2024
17ee81c
Update charts/ingress-nginx/tests/controller-poddisruptionbudget_test…
StuxxNet Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/ingress-nginx/templates/controller-poddisruptionbudget.yaml
View file
Open in desktop
@@ -1,4 +1,4 @@
{{- if or (and .Values.controller.autoscaling.enabled (gt (.Values.controller.autoscaling.minReplicas | int) 1)) (and (not .Values.controller.autoscaling.enabled) (gt (.Values.controller.replicaCount | int) 1)) }}
{{- if or (and .Values.controller.autoscaling.enabled (gt (.Values.controller.autoscaling.minReplicas | int) 1)) (and (not .Values.controller.autoscaling.enabled) (gt (.Values.controller.replicaCount | int) 1)) (and .Values.controller.keda.enabled (gt (.Values.controller.keda.minReplicas | int) 1))}}
StuxxNet marked this conversation as resolved.
Show resolved Hide resolved
apiVersion: {{ ternary "policy/v1" "policy/v1beta1" (semverCompare ">=1.21.0-0" .Capabilities.KubeVersion.Version) }}
kind: PodDisruptionBudget
metadata:
Expand Down
22 changes: 22 additions & 0 deletions charts/ingress-nginx/tests/controller-keda_pdb_test.yaml
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rename the file to charts/ingress-nginx/tests/controller-poddisruptionbudget_test.yaml. We used to have them named like the resources they are testing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! May you please check if the naming is correct now? :D

@@ -0,0 +1,22 @@
suite: Controller > Keda > PDB
templates:
- controller-poddisruptionbudget.yaml

tests:
- it: should create a PodDisruptionBudget if `controller.kind` is "Deployment" and `controller.keda.enabled` is true
set:
controller.kind: Deployment
controller.keda.enabled: true
controller.keda.minReplicas: 2
controller.minAvailable: 1
asserts:
- hasDocuments:
count: 1
- isKind:
of: PodDisruptionBudget
- equal:
path: metadata.name
value: RELEASE-NAME-ingress-nginx-controller
- equal:
path: spec.minAvailable
value: 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
value: 1
value: 1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suggestions adds the requite line feed at the end of the file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this was addressed in the last commit where the file was renamed :)