Skip to content

Commit

Permalink
fix(review): fixing typos
Browse files Browse the repository at this point in the history
  • Loading branch information
msfidelis committed Mar 27, 2024
1 parent ca0cf91 commit 1ca02d6
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
2 changes: 1 addition & 1 deletion pkg/flags/flags.go
Expand Up @@ -132,7 +132,7 @@ Requires setting the publish-service parameter to a valid Service reference.`)
electionID = flags.String("election-id", "ingress-controller-leader",
`Election id to use for Ingress status updates.`)

electionTTL = flags.Duration("election-ttl", 30*time.Second,
electionTTL = flags.Duration("election-ttl", 30 * time.Second,

Check failure on line 135 in pkg/flags/flags.go

View workflow job for this annotation

GitHub Actions / lint

File is not `gofmt`-ed with `-s` (gofmt)
`Duration a leader election is valid before it's getting re-elected`)

updateStatusOnShutdown = flags.Bool("update-status-on-shutdown", true,
Expand Down
3 changes: 0 additions & 3 deletions pkg/flags/flags_test.go
Expand Up @@ -17,7 +17,6 @@ limitations under the License.
package flags

import (
"fmt"
"os"
"testing"
"time"
Expand Down Expand Up @@ -158,8 +157,6 @@ func TestLeaderElectionTTLDefaultValue(t *testing.T) {
t.Fatalf("Unexpected error parsing default flags: %v", err)
}

fmt.Println(conf.ElectionTTL)

if conf.ElectionTTL != 30*time.Second {
t.Fatalf("Expected --election-ttl and conf.ElectionTTL as 30s, but found: %v", conf.ElectionTTL)
}
Expand Down

0 comments on commit 1ca02d6

Please sign in to comment.