Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3998: Uptdate JobSuccessPolicy API Name and Validations #4537

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

KEP-3998: Uptdate JobSuccessPolicy API Name and Validations #4537

wants to merge 3 commits into from

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Mar 5, 2024 •
edited

  • One-line PR description: I updated KEP based on implementations

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Mar 5, 2024
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 5, 2024
@tenzen-y
Copy link
Member Author

tenzen-y commented Mar 5, 2024

/cc @mimowo @alculquicondor @deads2k @soltysh

@tenzen-y
Copy link
Member Author

tenzen-y commented Mar 5, 2024

/cc @atiratree

alculquicondor
alculquicondor reviewed Mar 5, 2024
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alculquicondor, tenzen-y
Once this PR has been reviewed and has the lgtm label, please assign kow3ns for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y tenzen-y mentioned this pull request Mar 5, 2024
Open
15 tasks
@tenzen-y
Copy link
Member Author

tenzen-y commented Mar 6, 2024

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2024
@tenzen-y tenzen-y force-pushed the uptdate-successpolicy-api-name branch from 033db39 to b5d00b7 Compare March 8, 2024 16:26
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2024
@tenzen-y tenzen-y force-pushed the uptdate-successpolicy-api-name branch from b5d00b7 to 6c8d5c5 Compare March 8, 2024 16:28
@alculquicondor
Copy link
Member

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 8, 2024
@tenzen-y
Copy link
Member Author

tenzen-y commented Mar 8, 2024

/lgtm /hold cancel

I will add some status validation

@tenzen-y tenzen-y force-pushed the uptdate-successpolicy-api-name branch from 6c8d5c5 to a22a618 Compare March 8, 2024 16:51
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2024
@tenzen-y tenzen-y changed the title KEP-3998: Uptdate JobSuccessPolicy API Name KEP-3998: Uptdate JobSuccessPolicy API Name and Validations Mar 8, 2024
@tenzen-y
Copy link
Member Author

tenzen-y commented Mar 8, 2024

@alculquicondor @mimowo @soltysh @atiratree I updated the design based on actual implementations.
PTAL, thanks!

alculquicondor
alculquicondor reviewed Mar 8, 2024
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2024
@tenzen-y tenzen-y force-pushed the uptdate-successpolicy-api-name branch from a22a618 to 8f4c50a Compare March 11, 2024 13:24
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2024
@tenzen-y
Copy link
Member Author

@atiratree I addressed all comments. PTAL, thanks.

@tenzen-y
KEP-3998: Replace API name Criteria with Rules
a51b7ba 
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@tenzen-y
KEP-3998: Add validations for status.conditions
eda022d 
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@tenzen-y tenzen-y force-pushed the uptdate-successpolicy-api-name branch from 8f4c50a to 026cf09 Compare March 11, 2024 13:29
@atiratree
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2024
@tenzen-y
Copy link
Member Author

@soltysh Could you review this? Thanks.

sftim
sftim reviewed Apr 10, 2024
View reviewed changes
keps/sig-apps/3998-job-success-completion-policy/kep.yaml Outdated
@@ -5,7 +5,7 @@ authors:
owning-sig: sig-apps
participating-sigs:
- sig-apps
status: implementable
status: implemented
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AIUI we use implemented once the feature is generally available.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this is still alpha

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for checking this!
I didn't know that. I'm updating it!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dropped this commit.

@tenzen-y
KEP-3998: Replace int with int32 in the rules[*].succeededCount
b2f1695 
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@tenzen-y tenzen-y force-pushed the uptdate-successpolicy-api-name branch from 026cf09 to b2f1695 Compare April 11, 2024 21:04
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2024
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@tenzen-y
Copy link
Member Author

@soltysh Hi, Maciej, could you please check this PR? Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@atiratree atiratree atiratree left review comments

@sftim sftim sftim left review comments

@kow3ns kow3ns Awaiting requested review from kow3ns

@soltysh soltysh Awaiting requested review from soltysh

@deads2k deads2k Awaiting requested review from deads2k

@mimowo mimowo Awaiting requested review from mimowo

Assignees

@alculquicondor alculquicondor

@atiratree atiratree

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Apps
Status: Needs Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tenzen-y @k8s-ci-robot @alculquicondor @atiratree @sftim