Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-4368 update to use managedBy field instead of label #4530

Merged
merged 2 commits into from Mar 4, 2024
Merged

KEP-4368 update to use managedBy field instead of label #4530

merged 2 commits into from Mar 4, 2024

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented Mar 1, 2024 •
edited

  • One-line PR description:

Changes:

  • "managed-by" label -> "managedBy" field
  • beta stage -> alpha
  • added graduation criteria for beta "verify the validation passes during e2e tests for open-source projects (like Kueue and JobSet)"

The doc with the notes of the meeting where we took the decision to use field instead, shared with kubernetes-dev group.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Mar 1, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 1, 2024
@mimowo mimowo changed the title Kep update to use managedBy field instead of job WIP: KEP update to use managedBy field instead of job Mar 1, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 1, 2024
@mimowo mimowo mentioned this pull request Mar 1, 2024
Merged
@mimowo mimowo changed the title WIP: KEP update to use managedBy field instead of job WIP: KEP-4368 update to use managedBy field instead of job Mar 1, 2024
@mimowo mimowo changed the title WIP: KEP-4368 update to use managedBy field instead of job WIP: KEP-4368 update to use managedBy field instead of label Mar 1, 2024
@mimowo mimowo force-pushed the job-managed-by-kep branch 2 times, most recently from b0a6de5 to 5a1e21b Compare March 1, 2024 16:58
@mimowo
Copy link
Contributor Author

mimowo commented Mar 1, 2024

/cc @deads2k @soltysh @liggitt
Feel free to provide early feedback
/cc @wojtek-t
As PRR reviewer since this proposal now will go via Alpha.

@mimowo mimowo mentioned this pull request Mar 1, 2024
Open
8 tasks
@mimowo mimowo changed the title WIP: KEP-4368 update to use managedBy field instead of label KEP-4368 update to use managedBy field instead of label Mar 1, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 1, 2024
@wojtek-t wojtek-t self-assigned this Mar 4, 2024
@tenzen-y tenzen-y mentioned this pull request Mar 4, 2024
Closed
@wojtek-t
Copy link
Member

wojtek-t commented Mar 4, 2024

LGTM from the PRR perspective.

/approve PRR

@soltysh
Copy link
Contributor

soltysh commented Mar 4, 2024

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 4, 2024
soltysh
soltysh approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, soltysh, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit a8731d1 into kubernetes:master Mar 4, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannon92 kannon92 kannon92 left review comments

@tenzen-y tenzen-y tenzen-y left review comments

@soltysh soltysh soltysh approved these changes

@kow3ns kow3ns Awaiting requested review from kow3ns

@deads2k deads2k Awaiting requested review from deads2k

@liggitt liggitt Awaiting requested review from liggitt

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@soltysh soltysh

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
SIG Apps
Archived in project
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mimowo @wojtek-t @soltysh @k8s-ci-robot @kannon92 @tenzen-y