Order node addresses based on cluster stack type #689
Conversation
|
@krzykwas: GitHub didn't allow me to assign the following users: marqc. Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
cncf-cla: yes
|
This issue is currently awaiting triage. If the repository mantainers determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @krzykwas. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/L
|
|
||
| // Both internal and external IPv6 addresses are written to this array | ||
| ipv6s, err := metadata.Get(fmt.Sprintf(networkInterfaceIPV6, nic)) | ||
| if err != nil || ipv6s == "" { | ||
| klog.Infof("no internal IPV6 addresses found for node %v: %v", nodeName, err) | ||
| klog.Infof("No internal IPV6 addresses found for node %v: %v.", nodeName, err) |
There was a problem hiding this comment.
just an advice, you need to avoid modifying unrelated part of the code in the same commit
There was a problem hiding this comment.
These are tiny readability-related enhancements. I can revert them, though, and submit in a different PR. Please let me know.
There was a problem hiding this comment.
no, is not important, is for education, each commit has to be self contained, if you want to do unrelated changes you can use a different commit or a different PR, but if you make them in the same commit it is distracting for the reviewer and in case of reverts or bisect or cherry-pick it can have conflicts ...
k8s-ci-robot
added
the
ok-to-test
|
@aojea: GitHub didn't allow me to assign the following users: marqc. Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
removed
the
needs-ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, krzykwas, marqc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
|
/lgtm |
|
@marqc: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm |
k8s-ci-robot
added
the
lgtm
/assign @aojea
/assign @marqc