New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vpa - fix checkpoint gc of unknown recommenders #6767
base: master
Are you sure you want to change the base?
Conversation
The committers listed above are authorized under a signed CLA. |
Welcome @BojanZelic! |
Hi @BojanZelic. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BojanZelic, XiangningLi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
(I'm not an owner of this code and my review is meaningless) |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes the unintentional deletion of VPA checkpoints if using multiple recommenders
Which issue(s) this PR fixes:
Fixes #6387
Special notes for your reviewer:
Does this PR introduce a user-facing change?