test: add bats tests for csi-secrets-store-provider-alibabacloud #1091

DahuK · 2022-11-02T14:18:29Z

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
add bats test for a new provider from Alibaba Cloud

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:
Only the bats tests and testing yaml in this PR, please let me know what should I also prepare like the testing account AK, cluster or something else? Thanks a lot!

TODOs:

squashed commits
includes documentation
adds unit tests

aramase · 2022-11-07T19:45:29Z

/kind feature

aramase · 2022-11-07T19:45:53Z

/retitle test: add bats tests for csi-secrets-store-provider-alibabacloud

DahuK · 2022-11-16T14:13:53Z

@aramase I have refined this to pass our AK/SK from external secret and pass it into mount request from nodePublishSecretRef, please take your time to review this, thanks!

hixichen · 2022-12-07T04:44:23Z

Makefile

@@ -214,6 +215,9 @@ $(PROTOC): ## Install protoc
 $(YQ): ## Install yq for running the tests
 	curl -LO https://github.com/mikefarah/yq/releases/download/$(YQ_VERSION)/yq_linux_amd64 && chmod +x ./yq_linux_amd64 && mv yq_linux_amd64 /usr/local/bin/yq

+$(ALIYUNCLI): ## Install aliyun for running the tests
+	curl -LO https://github.com/aliyun/aliyun-cli/releases/download/v3.0.134/aliyun-cli-linux-3.0.134-amd64.tgz && tar xzvf aliyun-cli-linux-3.0.134-amd64.tgz && chmod +x ./aliyun && cp aliyun /usr/local/bin


is that possible to always test with latest aliyuncli?

Hi Xi, thanks for your review! for aliyuncli, seems there is no available latest download link.

hixichen · 2022-12-07T04:45:23Z

test/bats/tests/alibabacloud/pod-inline-volume-secretproviderclass.yaml

+kind: Pod
+apiVersion: v1
+metadata:
+  name: basic-test-mount


nit: aliyun-basic-test-mount?

have updated to alibabacloud-basic-test-mount

hixichen · 2022-12-07T04:46:20Z

test/bats/alibabacloud.bats

+
+setup_file() {
+    #Configure aliyun cli profile
+    aliyun configure set --profile akProfile --mode AK --region cn-hongkong --access-key-id ${ALIBABACLOUD_ACCESS_KEY} --access-key-secret ${ALIBABACLOUD_ACCESS_SECRET}


any specific reason to set cn-hongkong as default region?

refined to us-west-1 as default region

k8s-triage-robot · 2023-03-09T02:55:48Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

DahuK · 2023-03-09T07:20:54Z

@aramase @hixichen please check this again when you free, thx!

aramase · 2023-03-09T18:49:27Z

/remove-lifecycle stale

hixichen

LGTM

codecov-commenter · 2023-05-08T12:04:52Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.72%. Comparing base (bf86dbf) to head (8783658).
Report is 15 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1091      +/-   ##
==========================================
- Coverage   36.58%   35.72%   -0.86%     
==========================================
  Files          63       63              
  Lines        4532     3759     -773     
==========================================
- Hits         1658     1343     -315     
+ Misses       2730     2271     -459     
- Partials      144      145       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

DahuK · 2023-05-08T12:50:26Z

@aramase @hixichen @ritazh
this has held for a long time, could you please take a time for reviewing this and help to move forward, thanks!

Makefile

test/bats/alibabacloud.bats

test/bats/tests/alibabacloud/pod-inline-volume-secretproviderclass.yaml

k8s-triage-robot · 2024-01-19T06:57:06Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

aramase · 2024-01-19T18:29:29Z

/remove-lifecycle stale

k8s-triage-robot · 2024-04-18T18:39:45Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

aramase · 2024-04-19T05:21:01Z

/remove-lifecycle stale

k8s-ci-robot · 2024-04-21T12:31:29Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DahuK, hixichen
Once this PR has been reviewed and has the lgtm label, please assign tam7t for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

DahuK · 2024-04-21T12:36:06Z

@aramase The MR has been on hold for a long time, my apologies for the delayed update. Please review it and let me know if there's anything I need to add.

k8s-ci-robot · 2024-04-21T12:53:50Z

@DahuK: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-secrets-store-csi-driver-e2e-windows	`8783658`	link	true	`/test pull-secrets-store-csi-driver-e2e-windows`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 2, 2022

k8s-ci-robot requested review from aramase and tam7t November 2, 2022 14:18

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 2, 2022

aramase removed the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Nov 7, 2022

k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 7, 2022

k8s-ci-robot changed the title ~~add bats tests for csi-secrets-store-provider-alibabacloud~~ test: add bats tests for csi-secrets-store-provider-alibabacloud Nov 7, 2022

DahuK force-pushed the alibabacloud-bats-test branch from 90a855d to 5d2fc13 Compare November 16, 2022 13:50

hixichen reviewed Dec 7, 2022

View reviewed changes

DahuK force-pushed the alibabacloud-bats-test branch from 5d2fc13 to b9b9d48 Compare December 8, 2022 02:27

DahuK requested review from hixichen and removed request for tam7t and aramase December 9, 2022 02:02

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 9, 2023

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 9, 2023

hixichen approved these changes Apr 1, 2023

View reviewed changes

DahuK force-pushed the alibabacloud-bats-test branch from b9b9d48 to 5eb15fb Compare May 8, 2023 12:02

aramase requested changes May 18, 2023

View reviewed changes

DahuK force-pushed the alibabacloud-bats-test branch 2 times, most recently from cbb5461 to 32fe448 Compare May 19, 2023 15:10

DahuK requested a review from aramase May 19, 2023 15:11

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 19, 2024

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 19, 2024

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 18, 2024

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 19, 2024

add bats tests for alibabacloud secret store csi provider

8783658

DahuK force-pushed the alibabacloud-bats-test branch from 32fe448 to 8783658 Compare April 21, 2024 12:31

DahuK mentioned this pull request Apr 21, 2024

[kubernetes-sigs/secrets-store-csi-driver#1091]add optional presubmit for alibabacloud provider with secrets-store-csi kubernetes/test-infra#28032

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: add bats tests for csi-secrets-store-provider-alibabacloud #1091

test: add bats tests for csi-secrets-store-provider-alibabacloud #1091

DahuK commented Nov 2, 2022

aramase commented Nov 7, 2022

aramase commented Nov 7, 2022

DahuK commented Nov 16, 2022

hixichen Dec 7, 2022

DahuK Dec 8, 2022

hixichen Dec 7, 2022

DahuK Dec 8, 2022

hixichen Dec 7, 2022

DahuK Dec 8, 2022

k8s-triage-robot commented Mar 9, 2023

DahuK commented Mar 9, 2023

aramase commented Mar 9, 2023

hixichen left a comment

codecov-commenter commented May 8, 2023 •

edited

DahuK commented May 8, 2023

k8s-triage-robot commented Jan 19, 2024

aramase commented Jan 19, 2024

k8s-triage-robot commented Apr 18, 2024

aramase commented Apr 19, 2024

k8s-ci-robot commented Apr 21, 2024

DahuK commented Apr 21, 2024

k8s-ci-robot commented Apr 21, 2024

test: add bats tests for csi-secrets-store-provider-alibabacloud #1091

Are you sure you want to change the base?

test: add bats tests for csi-secrets-store-provider-alibabacloud #1091

Conversation

DahuK commented Nov 2, 2022

aramase commented Nov 7, 2022

aramase commented Nov 7, 2022

DahuK commented Nov 16, 2022

hixichen Dec 7, 2022

Choose a reason for hiding this comment

DahuK Dec 8, 2022

Choose a reason for hiding this comment

hixichen Dec 7, 2022

Choose a reason for hiding this comment

DahuK Dec 8, 2022

Choose a reason for hiding this comment

hixichen Dec 7, 2022

Choose a reason for hiding this comment

DahuK Dec 8, 2022

Choose a reason for hiding this comment

k8s-triage-robot commented Mar 9, 2023

DahuK commented Mar 9, 2023

aramase commented Mar 9, 2023

hixichen left a comment

Choose a reason for hiding this comment

codecov-commenter commented May 8, 2023 • edited

Codecov Report

DahuK commented May 8, 2023

k8s-triage-robot commented Jan 19, 2024

aramase commented Jan 19, 2024

k8s-triage-robot commented Apr 18, 2024

aramase commented Apr 19, 2024

k8s-ci-robot commented Apr 21, 2024

DahuK commented Apr 21, 2024

k8s-ci-robot commented Apr 21, 2024

codecov-commenter commented May 8, 2023 •

edited