-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semantic commit message #1397
base: master
Are you sure you want to change the base?
Semantic commit message #1397
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: CatherineF-dev The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cea100c
to
9aafc33
Compare
9aafc33
to
3ce7af8
Compare
It should fail on semantic testing. Waiting test result |
/retest |
Thank you for starting this initiative @CatherineF-dev I generally prefer the workflow in Kubernetes where users have to specify the changelog in their PR since it get rids of the noise. Do you have any thoughts on that @serathius @stevehipwell? |
/ok-to-test |
I think semantic commit message is better. If someone forgot to update changelog, we need to manually go through all changes again. |
If we're putting in a process I agree with @dgrisonnet that capturing CHANGELOG comments on the PR is better. |
/assign @dgrisonnet |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
What this PR does / why we need it: Improve release procedure. Before, we need to manually classify PRs in a new release, which is time-consuming. See #1165
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Following kubernetes/kube-state-metrics#1990