Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first draft of stylesheet #320

Merged
merged 2 commits into from Mar 8, 2024
Merged

Add first draft of stylesheet #320

merged 2 commits into from Mar 8, 2024

Conversation

jberkus
Copy link
Contributor

@jberkus jberkus commented Mar 1, 2024

Signed-off-by: Josh Berkus <josh@agliodbs.com>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jberkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 1, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 1, 2024
Copy link
Contributor

@mfahlandt mfahlandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions

* `--node-labels` has been around for 28 releases, [maybe it's not alpha anymore](https://github.com/kubernetes/kubernetes/pull/123061)
```

Version numbers can be reported as either bare or with a "v", whatever seems appropriate.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Version numbers can be reported as either bare or with a "v", whatever seems appropriate.
Version numbers can be reported as either bare or with a "v", whatever seems appropriate. In doubt use the formate the project/subproject is using.

STYLESHEET.md Outdated Show resolved Hide resolved
Co-authored-by: Mario <mfahlandt@pixel-haufen.de>
@jberkus
Copy link
Contributor Author

jberkus commented Mar 8, 2024

Merging this because the team urgently needs it

@jberkus jberkus merged commit e218ed9 into main Mar 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We should have a style guide for LWKD
3 participants