-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct grammar about using 'exec' #1074
Correct grammar about using 'exec' #1074
Conversation
Hi @network-charles. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for k8s-kwok ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/ok-to-test |
Should other APIs have the same problem and can you help to correct it together? |
Yes, they do. I'll correct it and update the release note. |
@wzshiming, I don't know why the test is failing. Let me know what you think, so I can decide if I will create a separate PR for my last commit or not. |
Need run |
Oh! Could it be because we are committing new contents to files in this folder on the script |
Yes, the CRD is maintained by the automatic, and the changes you make are inconsistent with it. |
e663a37
to
cb0b5a3
Compare
cb0b5a3
to
9fca551
Compare
This excludes files in the 'kustomize/crd/bases/' file path.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: network-charles The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@network-charles: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
It seems the test keeps failing even after I discarded the previous commit and created a new one. I'll delete this branch and try again with a new branch. |
What type of PR is this?
/kind cleanup
/kind documentation
What this PR does / why we need it:
While learning to use the
exec
feature, I realized some sentences have preposition issues. Prepositions use words like at, in, on, etc. to describe where things are, or how something is used. The sentences didn't describe how the noun "information" is used on a local target.I added "on" before "how" to correct this.
Does this PR introduce a user-facing change?