Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct grammar about using 'exec' #1074

Conversation

network-charles
Copy link
Contributor

@network-charles network-charles commented May 13, 2024

What type of PR is this?

/kind cleanup
/kind documentation

What this PR does / why we need it:

While learning to use the exec feature, I realized some sentences have preposition issues. Prepositions use words like at, in, on, etc. to describe where things are, or how something is used. The sentences didn't describe how the noun "information" is used on a local target.

I added "on" before "how" to correct this.

Does this PR introduce a user-facing change?

Sentences containing "information how to" have been removed and updated to "information on how to".

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels May 13, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @network-charles. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 13, 2024
Copy link

netlify bot commented May 13, 2024

Deploy Preview for k8s-kwok ready!

Name Link
🔨 Latest commit 80d8c3b
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/6644ff76334c77000848c396
😎 Deploy Preview https://deploy-preview-1074--k8s-kwok.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 13, 2024
@wzshiming
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 13, 2024
@wzshiming
Copy link
Member

Should other APIs have the same problem and can you help to correct it together?

@network-charles
Copy link
Contributor Author

Yes, they do. I'll correct it and update the release note.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 13, 2024
@network-charles
Copy link
Contributor Author

@wzshiming, I don't know why the test is failing. Let me know what you think, so I can decide if I will create a separate PR for my last commit or not.

@wzshiming
Copy link
Member

Need run ./hack/update-controllergen.sh to update CRD

@network-charles
Copy link
Contributor Author

Oh! Could it be because we are committing new contents to files in this folder on the script ${ROOT_DIR}/kustomize/crd/bases?

@wzshiming
Copy link
Member

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kwok/1074/pull-kwok-verify-main/1789979642556321792

Yes, the CRD is maintained by the automatic, and the changes you make are inconsistent with it.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 15, 2024
This excludes files in the 'kustomize/crd/bases/' file path.
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: network-charles
Once this PR has been reviewed and has the lgtm label, please assign yibozhuang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 15, 2024
@k8s-ci-robot
Copy link
Contributor

@network-charles: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kwok-verify-main 80d8c3b link true /test pull-kwok-verify-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@network-charles
Copy link
Contributor Author

It seems the test keeps failing even after I discarded the previous commit and created a new one. I'll delete this branch and try again with a new branch.

@network-charles network-charles deleted the network-charles-patch-1 branch May 15, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants