feature: added helm support

[dmitsh]

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds support for deploying kwok controller via Helm chart.

Which issue(s) this PR fixes:

Fixes #1029

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Support deployment of kwok controller and stages with helm charts

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dmitsh
Once this PR has been reviewed and has the lgtm label, please assign yibozhuang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @dmitsh. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[netlify]

✅ Deploy Preview for k8s-kwok canceled.

Name	Link
🔨 Latest commit	3bd9622
🔍 Latest deploy log	https://app.netlify.com/sites/k8s-kwok/deploys/663503900e377b00086e526d

[wzshiming]

It feels like there is a lot of duplication with kustomize.
Maybe we should get a way to convert the existing kustomize to a helm chart.

There is one more issue that needs to be discussed
Where is the release of the chart?

• Chart Repository
  • GitHub Pages of this repo?
  • ...
• OCI registry
  • registry.k8s.io/kwok/ (It's theoretically possible, but I haven't seen it done in other projects, and I don't know if it's supported by that CI.)?
  • docker.io ?
  • ghcr.io ?
  • ...

[wzshiming]

ln -s ../../kustomize/crd/bases crds

I think it should link to the original dir

[dmitsh]

If the goal is to convert kustomize to helm, then the originals should be in the helm chart?

[wzshiming]

I think there should be separate charts for deployment and stages,
the deployments should be renamed charts or helm.

WDYT?

[dmitsh]

Thanks! I have updated PR with these suggestions. PTAL.

[yuanchen8911]

You should put the release note inside the release-note block in the PR description. Also, I'd suggest something like the following in the release note.

Support helm chart

[wzshiming]

I found a project that converts yaml to charts.
https://github.com/arttor/helmify

IMAGE_PREFIX=registry.k8s.io/kwok GIT_TAG=v0.5.2 make manifests
cat artifacts/kwok.yaml | go run github.com/arttor/helmify/cmd/helmify@v0.4.12 -crd-dir ./charts/kwok
cat artifacts/stage-fast.yaml | sed -e 's#{{#{{`{{#g' -e 's#}}#}}`}}#g' | go run github.com/arttor/helmify/cmd/helmify@v0.4.12 -original-name ./charts/stage-fast

It feels good.

Next, It would be nice to add an ./hack/update-charts.sh and ./hack/verify-charts.sh to keep the two in sync.

[yuanchen8911]

/ok-to-test

[k8s-ci-robot]

@dmitsh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kwok-verify-main	3bd9622	link	true	/test pull-kwok-verify-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[wzshiming]

Hi @dmitsh , do you have time to work on this PR? If not I'll continue this.